Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade @grpc/grpc-js to v1.10.3 #3127

Conversation

petermetz
Copy link
Contributor

  1. This is a pre-requisite for a bigger change that is adding gRPC endpoint support to the plugins.
  2. We've had gRPC support in the API server for a long time, but the plugins are not yet able to register their own gRPC services as of now.
  3. The reason we need the newer version is because some types are not exported by the older version that we'll be using to implement the gRPC support for plugins.

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. This is a pre-requisite for a bigger change that is adding gRPC
endpoint support to the plugins.
2. We've had gRPC support in the API server for a long time, but the
plugins are not yet able to register their own gRPC services as of now.
3. The reason we need the newer version is because some types are not
exported by the older version that we'll be using to implement the
gRPC support for plugins.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz
Copy link
Contributor Author

Oops, duplicated this PR accidentally. Closing!

@petermetz petermetz closed this Mar 19, 2024
@petermetz petermetz deleted the build-upgrade-grpc-js-v1-10-3 branch May 24, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant