-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(carbon-accounting): fix CVE-2022-25881 CVE-2021-39167 #3146
chore(carbon-accounting): fix CVE-2022-25881 CVE-2021-39167 #3146
Conversation
e38a39c
to
f49d52a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldousalvarez Please specify in the commit subject and the PR title the top 1 or 2 CVEs that are being addressed by the pull request so that it is as unique as possible within the 72 characters limit.
f0107af
to
8665694
Compare
@petermetz Already updated it with the top 2 CVEs that are being addressed by this pull request. With this fix we can also close the issue #2718 because all the vulnerabilities are now fixed by this PR |
@aldousalvarez Run |
8665694
to
6f1f1cc
Compare
6f1f1cc
to
eeceff4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldousalvarez We are almost there! Please fix the PR lint check that currently is failing and also make sure to rebase onto upstream/main
because there are some fixes in there that you'll need to have the build passing in general.
Primary Changes ---------------- 1. Modified the Dockerfile to use the updated versions of the packages being used 2. Modified the supervisord.conf to use the correct path because it has changed after updating the versions Fixes hyperledger-cacti#2062 Signed-off-by: aldousalvarez <[email protected]>
eeceff4
to
c0df430
Compare
@petermetz already fixed it, PR lint check is now passing and is up to date with the upstream/main |
Commit to be reviewed
examples(carbon-accounting):fix CVE-2022-25881 CVE-2021-39167
Fixes #2062
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.