feat(corda): support 5.1 via TS/HTTP (no JVM) #3241

adrianbatuto · 2024-05-01T10:02:09Z

Commit to be reviewed

feat(corda): support 5.1 via TS/HTTP (no JVM)

Primary Changes
----------------
1. Updated plugin-ledger-connector corda to support Corda 5
2. Created corda-v5-flow.test for testing the Corda 5 endpoints

Fixes #2978
Fixes #3293
Pull Request Requirements

Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

...cactus-plugin-ledger-connector-corda/src/main/typescript/web-services/get-cpi-endpoint-v1.ts

...es/cactus-plugin-ledger-connector-corda/src/main/typescript/plugin-ledger-connector-corda.ts

jagpreetsinghsasan

@adrianbatuto we will need another issue to update some code changes. Mentioning it here so that we don't loos the track of the same.

Update each new endpoint function (in the connector class) to use one universal function to do GET/POST (Currently the universal function, setupRequest, does only the basic initialization)
Update the AIO to not use --network host tag so that it can be tested via CI

packages/cactus-plugin-ledger-connector-corda/src/main-server/healthcheck.sh

packages/cactus-plugin-ledger-connector-corda/src/main-server/start-app.sh

packages/cactus-plugin-ledger-connector-corda/src/main/json/openapi.json

...s/cactus-plugin-ledger-connector-corda/src/test/typescript/integration/corda-v5-flow.test.ts

packages/cactus-test-tooling/src/main/typescript/corda/corda-v5-test-ledger.ts

...es/cactus-plugin-ledger-connector-corda/src/main/typescript/plugin-ledger-connector-corda.ts

...actus-plugin-ledger-connector-corda/src/main/typescript/web-services/list-cpi-endpoint-v1.ts

petermetz

@adrianbatuto Two questions:

Does this work without the JVM app? I see you've made changes to the kotlin code.
Would merging this still retain compatibility with 4.x Corda ledgers?

jagpreetsinghsasan

Blocking the PR for now as the image used in this from @adrianbatuto personal github registry.
Once the AIO docker image gets published from the Cacti account itself, the process of merging of this PR can progress.

adrianbatuto · 2024-05-21T04:09:52Z

@adrianbatuto Two questions:

Does this work without the JVM app? I see you've made changes to the kotlin code.

Would merging this still retain compatibility with 4.x Corda ledgers?

Yes it is working without the JVM app. The changes to the kotlin code happened after running yarn run codegen.
It should retain compatibility with Corda 4. I also ran some of the existing tests for Corda 4 to make sure.

...es/cactus-plugin-ledger-connector-corda/src/main/typescript/plugin-ledger-connector-corda.ts

packages/cactus-plugin-ledger-connector-corda/src/main/json/openapi.json

adrianbatuto · 2024-05-27T04:19:13Z

The corda-v5-flow.test.ts is getting flaky results so I added a timeout as a temporary fix. I will look further into the issue and a separate ticket might be created for it.

adrianbatuto · 2024-05-27T05:41:03Z

Blocking the PR for now as the image used in this from @adrianbatuto personal github registry. Once the AIO docker image gets published from the Cacti account itself, the process of merging of this PR can progress.

@jagpreetsinghsasan this has been resolved.

petermetz

@adrianbatuto - OK, thank you for confirming the answers and the PR.

@jagpreetsinghsasan Please make sure that the follow-up issues are opened and added to the board! Thank you in advance!

jagpreetsinghsasan · 2024-06-04T05:19:34Z

@petermetz we have added the follow up tasks with the flakiness fix being the highest priority task in the queue followed by the cordapps feature issue.
This PR looks good to me now and can be merged once @adrianbatuto rebase it and fix conflicts and we have a merge consensus from other maintainers.

jagpreetsinghsasan · 2024-06-12T07:42:58Z

@hyperledger/cacti-maintainers

petermetz · 2024-06-13T15:36:23Z

@petermetz we have added the follow up tasks with the flakiness fix being the highest priority task in the queue followed by the cordapps feature issue. This PR looks good to me now and can be merged once @adrianbatuto rebase it and fix conflicts and we have a merge consensus from other maintainers.

@jagpreetsinghsasan Thank you! Agreed on all of those!

...es/cactus-plugin-ledger-connector-corda/src/main/typescript/plugin-ledger-connector-corda.ts

...tus-plugin-ledger-connector-corda/src/main/typescript/web-services/start-flow-endpoint-v1.ts

petermetz

@adrianbatuto Sorry, I wasn't perfectly clear in one of my comments: https://github.com/hyperledger/cacti/pull/3241#discussion_r1712368658

petermetz

@adrianbatuto We are almost there!

...actus-plugin-ledger-connector-corda/src/main/typescript/web-services/get-flow-endpoint-v1.ts

petermetz

@adrianbatuto Looking good! Now the last thing (hopefully) is to fix the failing corda connector server build

Cactus_CI / ghcr-connector-corda-server (pull_request) Failing after 1m
Details

adrianbatuto · 2024-08-19T05:03:35Z

@adrianbatuto Looking good! Now the last thing (hopefully) is to fix the failing corda connector server build

Cactus_CI / ghcr-connector-corda-server (pull_request) Failing after 1m
Details

@petermetz, I fixed the build error and now the check is failing because of vulnerability issues.

Fixes hyperledger-cacti#2978 Fixes hyperledger-cacti#3293 Signed-off-by: adrianbatuto <[email protected]>

petermetz · 2024-08-19T21:42:48Z

@adrianbatuto Thanks for the fix, we can address the trivy vulnerabilities later in a different PR, so, looking good to me now.

github-advanced-security bot found potential problems May 1, 2024

View reviewed changes

jagpreetsinghsasan requested changes May 2, 2024

View reviewed changes

adrianbatuto force-pushed the adrianbatuto/issue2978 branch from 0eb899e to 38c5858 Compare May 9, 2024 05:11

adrianbatuto requested a review from jagpreetsinghsasan May 9, 2024 05:14

github-advanced-security bot found potential problems May 9, 2024

View reviewed changes

adrianbatuto marked this pull request as ready for review May 9, 2024 07:27

adrianbatuto requested review from petermetz, takeutak, izuru0, VRamakrishna, sandeepnRES and outSH as code owners May 9, 2024 07:27

petermetz reviewed May 17, 2024

View reviewed changes

jagpreetsinghsasan previously requested changes May 20, 2024

View reviewed changes

petermetz requested changes May 24, 2024

View reviewed changes

adrianbatuto force-pushed the adrianbatuto/issue2978 branch from 38c5858 to 05a9288 Compare May 27, 2024 04:15

adrianbatuto force-pushed the adrianbatuto/issue2978 branch from 05a9288 to 97811b8 Compare May 28, 2024 05:56

adrianbatuto requested review from petermetz and jagpreetsinghsasan May 28, 2024 06:01

petermetz approved these changes May 31, 2024

View reviewed changes

This was referenced Jun 4, 2024

test(connector-corda): fix flaky corda-v5-flow.test.ts #3293

Closed

feat(corda): add cordapps deployment for Corda 5 #3294

Open

adrianbatuto force-pushed the adrianbatuto/issue2978 branch from 97811b8 to 7a03e5d Compare June 12, 2024 10:07

adrianbatuto force-pushed the adrianbatuto/issue2978 branch from 7a03e5d to 8273248 Compare June 14, 2024 08:33

adrianbatuto force-pushed the adrianbatuto/issue2978 branch from 5c1abee to 15069c2 Compare July 23, 2024 03:21

github-advanced-security bot found potential problems Jul 23, 2024

View reviewed changes

...es/cactus-plugin-ledger-connector-corda/src/main/typescript/plugin-ledger-connector-corda.ts Fixed Show fixed Hide fixed

adrianbatuto force-pushed the adrianbatuto/issue2978 branch 4 times, most recently from 9014731 to ebdb9ee Compare July 23, 2024 03:44

adrianbatuto requested a review from petermetz July 23, 2024 04:03

petermetz requested changes Jul 31, 2024

View reviewed changes

...tus-plugin-ledger-connector-corda/src/main/typescript/web-services/start-flow-endpoint-v1.ts Outdated Show resolved Hide resolved

adrianbatuto force-pushed the adrianbatuto/issue2978 branch from ebdb9ee to a93e56c Compare August 5, 2024 09:32

adrianbatuto requested a review from petermetz August 5, 2024 09:33

petermetz requested changes Aug 9, 2024

View reviewed changes

adrianbatuto force-pushed the adrianbatuto/issue2978 branch 3 times, most recently from a0397ad to c960449 Compare August 12, 2024 06:37

adrianbatuto requested a review from petermetz August 12, 2024 07:30

petermetz requested changes Aug 12, 2024

View reviewed changes

adrianbatuto force-pushed the adrianbatuto/issue2978 branch 2 times, most recently from 3cd5b23 to 5e7ff7b Compare August 15, 2024 10:54

adrianbatuto requested a review from petermetz August 15, 2024 10:54

petermetz requested changes Aug 16, 2024

View reviewed changes

adrianbatuto force-pushed the adrianbatuto/issue2978 branch from 5e7ff7b to 755e177 Compare August 19, 2024 04:54

adrianbatuto requested a review from petermetz August 19, 2024 05:03

feat(corda): support 5.1 via TS/HTTP (no JVM)

35e3ff3

Fixes hyperledger-cacti#2978 Fixes hyperledger-cacti#3293 Signed-off-by: adrianbatuto <[email protected]>

adrianbatuto force-pushed the adrianbatuto/issue2978 branch from 755e177 to 35e3ff3 Compare August 19, 2024 06:28

petermetz approved these changes Aug 19, 2024

View reviewed changes

petermetz merged commit ec9683d into hyperledger-cacti:main Aug 19, 2024
143 of 145 checks passed

petermetz deleted the adrianbatuto/issue2978 branch August 19, 2024 21:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(corda): support 5.1 via TS/HTTP (no JVM) #3241

feat(corda): support 5.1 via TS/HTTP (no JVM) #3241

adrianbatuto commented May 1, 2024 •

edited

Loading

jagpreetsinghsasan left a comment •

edited

Loading

petermetz left a comment

jagpreetsinghsasan left a comment

adrianbatuto commented May 21, 2024

adrianbatuto commented May 27, 2024

adrianbatuto commented May 27, 2024 •

edited

Loading

petermetz left a comment

jagpreetsinghsasan commented Jun 4, 2024

jagpreetsinghsasan commented Jun 12, 2024

petermetz commented Jun 13, 2024

petermetz left a comment

petermetz left a comment

petermetz left a comment •

edited

Loading

adrianbatuto commented Aug 19, 2024

petermetz commented Aug 19, 2024

feat(corda): support 5.1 via TS/HTTP (no JVM) #3241

feat(corda): support 5.1 via TS/HTTP (no JVM) #3241

Conversation

adrianbatuto commented May 1, 2024 • edited Loading

Commit to be reviewed

jagpreetsinghsasan left a comment • edited Loading

Choose a reason for hiding this comment

petermetz left a comment

Choose a reason for hiding this comment

jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

adrianbatuto commented May 21, 2024

adrianbatuto commented May 27, 2024

adrianbatuto commented May 27, 2024 • edited Loading

petermetz left a comment

Choose a reason for hiding this comment

jagpreetsinghsasan commented Jun 4, 2024

jagpreetsinghsasan commented Jun 12, 2024

petermetz commented Jun 13, 2024

petermetz left a comment

Choose a reason for hiding this comment

petermetz left a comment

Choose a reason for hiding this comment

petermetz left a comment • edited Loading

Choose a reason for hiding this comment

adrianbatuto commented Aug 19, 2024

petermetz commented Aug 19, 2024

adrianbatuto commented May 1, 2024 •

edited

Loading

jagpreetsinghsasan left a comment •

edited

Loading

adrianbatuto commented May 27, 2024 •

edited

Loading

petermetz left a comment •

edited

Loading