-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(devcontainer): add trivy and its VSCode Extension #3307
docs(devcontainer): add trivy and its VSCode Extension #3307
Conversation
f5ce721
to
499fef9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashnashahgrover LGTM with comments
499fef9
to
b9203b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @ashnashahgrover (You still have to update the commit message, some typos and point 4 is not valid anymore)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashnashahgrover Are you still working on this? If not, we can close it down and pick it back up later. I'm trying to keep the PR queue fresh. |
b9203b6
to
52d56f4
Compare
52d56f4
to
082dcec
Compare
082dcec
to
86a0c08
Compare
@ashnashahgrover please read the PR message again (and similarly, commit message) |
3a9d66a
to
8a99b95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashnashahgrover Seems like a rebase gone wrong type of situation. Please remove the non-relevant lines from the diff.
8a99b95
to
bbca40d
Compare
@petermetz I deleted the non-relevant lines, please let me know if you still see any issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashnashahgrover The diff still has parts that looks like parts of a different commit / older version of the file:
bbca40d
to
0863051
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashnashahgrover are you still working on this? If yes please rebase with latest main and address the other comments please.
0863051
to
8253bb4
Compare
3d5f5c4
to
6e860d9
Compare
@RafaelAPB, all changes have been addressed can you re review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Primary Changes 1) updated trivy version in the .devcontainer file and included trivy vs-code extension Changes required to incorporate 1) 3) included trivy vs-code extension in the .vscode/extensions.json file Fixes hyperledger-cacti#2650 Signed-off-by: ashnashahgrover <[email protected]>
6e860d9
to
2d55d1c
Compare
Primary Changes
Changes required to incorporate 1)
3) included trivy vs-code extension in the .vscode/extensions.json file
Fixes https://github.com/hyperledger/cacti/issues/2650
Signed-off-by: ashnashahgrover [email protected]
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.