feat(persistence-ethereum): migrate to separate db schema #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
|
This PR/issue depends on:
|
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Jul 11, 2024
- Read gui supabase connection information from environment variable. Include `.env` files in common `.gitignore` file. Change ledger-browser typescript target and module to `esnext` to use vite environment variables. - Read app configuration from the supabase DB. - Add button on home page for adding new application. Clicking on it will open dialog with setup wizzard. User must filter apps by it's group (step 1), select the app (step 2), input common app configuration data (step 3) and lastly input app-specific configuration (JSON format). - Add button to configure already added app. It opens a dialog that allows editing app details in the database. It also contains a button for deleting the app (after confirmation). - Show full screen error message with setup guidelines when app has failed to connect to supabase. - Clean up supabase type files, move app-related typedefs to specific app dirs. Depends on hyperledger-cacti#3347 Signed-off-by: Michal Bajer <[email protected]>
5 tasks
outSH
force-pushed
the
move_eth_persistence_to_separate_schema_pr
branch
from
81d7bfd to
abfe25b
Compare
outSH
force-pushed
the
move_eth_persistence_to_separate_schema_pr
branch
from
abfe25b to
57608bd
Compare
|
@petermetz Done, ready for review :) |
petermetz
approved these changes
Aug 9, 2024
- Move all database entities relating to ethereum persistence plugin to a seprate schema. Adjust all the files the test to work as expected after that change. - Remove sample SQL data from GUI package, one from persistence packages should be used instead. - Upgrade web3-utils in persistence-ethereum to fix a bug when running the standalone script. Depends on hyperledger-cacti#3340 Signed-off-by: Michal Bajer <[email protected]>
petermetz
force-pushed
the
move_eth_persistence_to_separate_schema_pr
branch
from
57608bd to
3aca556
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Aug 12, 2024
- Read gui supabase connection information from environment variable. Include `.env` files in common `.gitignore` file. Change ledger-browser typescript target and module to `esnext` to use vite environment variables. - Read app configuration from the supabase DB. - Add button on home page for adding new application. Clicking on it will open dialog with setup wizzard. User must filter apps by it's group (step 1), select the app (step 2), input common app configuration data (step 3) and lastly input app-specific configuration (JSON format). - Add button to configure already added app. It opens a dialog that allows editing app details in the database. It also contains a button for deleting the app (after confirmation). - Show full screen error message with setup guidelines when app has failed to connect to supabase. - Clean up supabase type files, move app-related typedefs to specific app dirs. Depends on hyperledger-cacti#3347 Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
that referenced
this pull request
Aug 12, 2024
- Read gui supabase connection information from environment variable. Include `.env` files in common `.gitignore` file. Change ledger-browser typescript target and module to `esnext` to use vite environment variables. - Read app configuration from the supabase DB. - Add button on home page for adding new application. Clicking on it will open dialog with setup wizzard. User must filter apps by it's group (step 1), select the app (step 2), input common app configuration data (step 3) and lastly input app-specific configuration (JSON format). - Add button to configure already added app. It opens a dialog that allows editing app details in the database. It also contains a button for deleting the app (after confirmation). - Show full screen error message with setup guidelines when app has failed to connect to supabase. - Clean up supabase type files, move app-related typedefs to specific app dirs. Depends on #3347 Signed-off-by: Michal Bajer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a seprate schema. Adjust all the files the test to work as expected after
that change.
be used instead.
standalone script.
Depends on https://github.com/hyperledger/cacti/pull/3340
Signed-off-by: Michal Bajer [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.