Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector-corda): add initial set of JvmObject factory functions #3357

Conversation

petermetz
Copy link
Contributor

  1. These functions are used so more easily construct the JSON representation
    of JVM objects (references and primitive values) that we need to define when
    interacting with the Corda JVM connector (which is used for Corda v4 ledgers)
  2. This is not a comprehensive set but more like a trailblazing initial
    implementation to showcase how to create and use these factory functions.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. These functions are used so more easily construct the JSON representation
of JVM objects (references and primitive values) that we need to define when
interacting with the Corda JVM connector (which is used for Corda v4 ledgers)
2. This is not a comprehensive set but more like a trailblazing initial
implementation to showcase how to create and use these factory functions.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the feat-connector-corda-jvm-object-factories-initial-set branch from aa23da3 to e6576ce Compare June 27, 2024 05:43
@petermetz petermetz merged commit d9d5904 into hyperledger-cacti:main Jun 27, 2024
147 of 150 checks passed
@petermetz petermetz deleted the feat-connector-corda-jvm-object-factories-initial-set branch June 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants