-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(weaver): use docker compose v2 #3372
chore(weaver): use docker compose v2 #3372
Conversation
3d7a064
to
83fbf91
Compare
Hi @jenniferlianne Can you update the version of docker compose in docs: |
2ceaca2
to
b23c4f5
Compare
@sandeepnRES I have updated all 10 weaver doc .md files that make reference to the Docker Compose version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jenniferlianne LGTM, thank you!
Just noting that this PR is a replacement for #3358. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jenniferlianne Please undo all changes within weaver/docs/
. I've submitted another PR (to be merged today) where I delete that folder entirely as it was already deprecated (moved to the docs
folder in the root) last year: https://github.com/hyperledger/cacti/pull/3358.
b23c4f5
to
2cf16f3
Compare
I have removed the changes to weaver/docs as requested by @VRamakrishna. |
Primary change: Updates the weaver files to use docker compose v2 syntax. docker-compose v1 will be dropped on the github runners shortly. Signed-off-by: Jennifer Bell <[email protected]>
2cf16f3
to
7c85f25
Compare
Primary change: Updates the weaver files to use docker compose v2 syntax. docker-compose v1 will be dropped on the github runners shortly.
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.