Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): migrate supply chain app to XDai connector #3380

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

petermetz
Copy link
Contributor

  1. We are in the process of decomissioning the Quorum connector and this
    is a pre-requisite to that end.

Depends on #3379

test(test-tooling): fix BesuTestLedger start cfg: publish all ports)

Fixes #3272

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz force-pushed the petermetz/issue3272 branch from 8a5d6a8 to a08870e Compare July 6, 2024 03:12
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz changed the title docs(examples): migrate supply chain app to XDai connector docs(examples): migrate supply chain app to XDai connector Jul 8, 2024
@github-actions github-actions bot removed the dependent label Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

This PR/issue depends on:

@petermetz petermetz force-pushed the petermetz/issue3272 branch from a08870e to 6cb382a Compare July 8, 2024 16:39
1. We are in the process of decomissioning the Quorum connector and this
is a pre-requisite to that end.

Depends on hyperledger-cacti#3379
> test(test-tooling): fix BesuTestLedger start cfg: publish all ports)

Fixes hyperledger-cacti#3272

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the petermetz/issue3272 branch from 6cb382a to e62ae86 Compare July 8, 2024 16:45
@petermetz petermetz merged commit 997ee75 into hyperledger-cacti:main Jul 8, 2024
147 of 150 checks passed
@petermetz petermetz deleted the petermetz/issue3272 branch July 8, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(examples): migrate supply chain app to ethereum connector
3 participants