build: bump [email protected] [email protected] @bufbuild/[email protected] #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
RafaelAPB,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
BREAKING CHANGE: Renamed classes to fix typos in their name: `PluginFactoryPersistanceFabric` This is being done in this pull request because for some reason (that I still don't understand) the spell checker started failing on these only in the context of this pull request. The typos were present on the main branch already somehow having passed spellchecking earlier and every other time since then. And also - [email protected] - [email protected] - [email protected] - [email protected] Quality of life improvements and also hoping to get rid of a few of the vulnerable dependency versions we have in the codebase according to dependabot. More similar changes are coming in with further upgrades but I want to avoid making bigger changes in one go so that it's easier to hunt down bugs later if something only gets discovered after we've merged a bunch of these. Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
build-deps-upgrade-uuid-cspell-bufbuild
branch
from
a31e00f to
7b43791
Compare
outSH
approved these changes
Jul 8, 2024
|
@petermetz Sure, no problem, done similar changes in #3308 |
jagpreetsinghsasan
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Renamed classes to fix typos in their name:
PluginFactoryPersistanceFabricThis is being done in this pull request because for some reason (that I still don't understand)
the spell checker started failing on these only in the context of this pull request.
The typos were present on the main branch already somehow having passed spellchecking earlier
and every other time since then.
And also
Quality of life improvements and also hoping to get rid of a few of the
vulnerable dependency versions we have in the codebase according to
dependabot.
More similar changes are coming in with further upgrades but I want to
avoid making bigger changes in one go so that it's easier to hunt down
bugs later if something only gets discovered after we've merged a bunch
of these.
Signed-off-by: Peter Somogyvari [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.