Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector-corda): fix flow-database-access-v4-8 test case #3388

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Jul 8, 2024

Primary Change:

  1. The test case was broken due to a number of different issues related
    to the AIO image build an also the connector image build, but on top of
    those problems it also had misconfiguration issues where the port number
    wasn't set to what it should be for the RPC connection that the connector
    container uses to establish communications with the AIO ledger image.

Secondary Change(s):

  1. Fixed 2 bugs in the test tooling package where the port configuration
    was not randomizing the exposed ports of the corda connector container and
    the corda test ledger leading to accessibility issues.
  2. Also introduced a createJvmInt(...) utility function on the corda connector
    package which allows the flowdb test case to construct the flow invocation
    requests with much less manual labor (manual coding).

In order to properly verify that this test case is working, a few other
pull requests have to be merged first and container images from those
sources published as well.

In addition to the pull request dependencies we also depend on a permission
issue being resolved in the larger GitHub organization itself as well:
hyperledger/governance#299

Depends on #3386
Depends on #3387

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz force-pushed the test-tooling-fix-corda-test-ledger-port-publish-cfg branch from f833fa4 to 224ae98 Compare July 9, 2024 17:52
@github-actions github-actions bot removed the dependent label Jul 9, 2024
@petermetz petermetz marked this pull request as ready for review July 9, 2024 17:52
Copy link

github-actions bot commented Jul 9, 2024

This PR/issue depends on:

  • hyperledger/cacti#3386
  • hyperledger/cacti#3387
    By Dependent Issues (🤖). Happy coding!

@petermetz petermetz requested a review from RafaelAPB July 9, 2024 17:52
@petermetz petermetz changed the title test(connector-corda): fix flow-database-access-v4-8 test case test(connector-corda): fix flow-database-access-v4-8 test case Jul 9, 2024
@petermetz petermetz force-pushed the test-tooling-fix-corda-test-ledger-port-publish-cfg branch from 224ae98 to 69247bc Compare July 10, 2024 05:27
Primary Change:
---------------

1. The test case was broken due to a number of different issues related
to the AIO image build an also the connector image build, but on top of
those problems it also had misconfiguration issues where the port number
wasn't set to what it should be for the RPC connection that the connector
container uses to establish communications with the AIO ledger image.

Secondary Change(s):
---------------------
1. Fixed 2 bugs in the test tooling package where the port configuration
was not randomizing the exposed ports of the corda connector container and
the corda test ledger leading to accessibility issues.
2. Also introduced a createJvmInt(...) utility function on the corda connector
package which allows the flowdb test case to construct the flow invocation
requests with much less manual labor (manual coding).

In order to properly verify that this test case is working, a few other
pull requests have to be merged first and container images from those
sources published as well.

In addition to the pull request dependencies we also depend on a permission
issue being resolved in the larger GitHub organization itself as well:
hyperledger/governance#299

Depends on hyperledger-cacti#3386
Depends on hyperledger-cacti#3387

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-tooling-fix-corda-test-ledger-port-publish-cfg branch from 69247bc to 4aeca6c Compare July 10, 2024 16:21
@petermetz petermetz merged commit 06cb8d0 into hyperledger-cacti:main Jul 10, 2024
137 of 146 checks passed
@petermetz petermetz deleted the test-tooling-fix-corda-test-ledger-port-publish-cfg branch July 10, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants