Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector-fabric): decode blocks in getTransactionReceiptByTxID() #3405

Merged

Conversation

petermetz
Copy link
Contributor

Since commit 8c030ae we have to
manually decode the protocol buffer block data because the
querySystemChainCode() does not do it for us by default anymore.

This was causing some type-checks to fail in getTransactionReceiptByTxID()
which were explicitly guarding against receiving Buffers as responses
but now the only thing we receive from the query system chain code method
is exactly Buffer type objects.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for missing this case

@petermetz
Copy link
Contributor Author

LGTM, sorry for missing this case

@outSH It's all good, a lot of them slips past me too. I'm hoping to have the CI go full green soon and then we can turn all (or at least more than now) checks back to being "required". And then these kind of issues will get caught automatically (or at least most of them hehe) :-)

Thank you for the swift review, very much appreciated!

Since commit 8c030ae we have to
manually decode the protocol buffer block data because the
querySystemChainCode() does not do it for us by default anymore.

This was causing some type-checks to fail in getTransactionReceiptByTxID()
which were explicitly guarding against receiving `Buffer`s as responses
but now the only thing we receive from the query system chain code method
is exactly `Buffer` type objects.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-bungee-fix-api-test branch from c64832b to 26a99b9 Compare July 15, 2024 17:24
@petermetz petermetz disabled auto-merge July 15, 2024 17:27
@petermetz petermetz merged commit 1bdc35d into hyperledger-cacti:main Jul 15, 2024
142 of 143 checks passed
@petermetz petermetz deleted the test-bungee-fix-api-test branch July 15, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants