-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector-daml): aio image #3411
feat(connector-daml): aio image #3411
Conversation
@raynatopedrajeta please fix the PR message and the commit message (similar to how you did earlier, in your previous PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this PR from a possible merge, until the review comments are addressed.
eaa8712
to
455ca58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise!
5f432b0
to
f1b93d3
Compare
c095289
to
ed66bb3
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
ed66bb3
to
83d928c
Compare
de49001
to
54c611a
Compare
345b325
to
feca662
Compare
51e6967
to
c822be3
Compare
176a870
to
6b1fb0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the updates!
@jagpreetsinghsasan Are we good to go from your side? |
Yes @petermetz , good to merge from my end. |
Jagpreet confirmed that the requests have been made.
Primary Changes --------------- 1. Create a docker image on daml-all-in-one folder that contains an initial creation of DAML smart contracts Fixes hyperledger-cacti#3284 Signed-off-by: raynato.c.pedrajeta <[email protected]>
6b1fb0f
to
af98f04
Compare
Commit to be reviewed
feat(connector-daml): aio image
Fixes #3284
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.