Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): upgrade to Angular v17.x.x project-wide #3412

Merged

Conversation

aldousalvarez
Copy link
Contributor

@aldousalvarez aldousalvarez commented Jul 15, 2024

Commit to be reviewed


docs(examples): upgrade to Angular v17.x.x project-wide

Primary Changes
----------------
1. Upgraded Angular to use version 17.x.x and also its dependencies.

Fixes #3063

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Primary Changes
----------------
1. Upgraded Angular to use version 17.x.x and also its dependencies.

Fixes hyperledger-cacti#3063

Signed-off-by: aldousalvarez <[email protected]>
@petermetz petermetz force-pushed the aldousalvarez/issue3063 branch from 792f402 to 5dd60a2 Compare July 15, 2024 17:56
@petermetz petermetz merged commit 40c391f into hyperledger-cacti:main Jul 15, 2024
141 of 143 checks passed
@petermetz petermetz deleted the aldousalvarez/issue3063 branch July 15, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(examples): upgrade to Angular v17.x.x project-wide
3 participants