Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): persistently bump word-wrap from 1.2.3 to >=1.2.5 #3419

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

ruzell22
Copy link
Contributor

@ruzell22 ruzell22 commented Jul 17, 2024

Commit to be reviewed


build(deps): persistently bump word-wrap from 1.2.3 to >=1.2.5

Primary Changes
---------------

1. Added word-wrap in resolutions in package.json

Fixes: #2569

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run yarn install to update the yarn.lock file

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruzell22 LGMT once the change request from @outSH is addressed. Thank you!

@ruzell22 ruzell22 force-pushed the wordwrap2569 branch 2 times, most recently from c90dea5 to d19e84c Compare July 18, 2024 00:54
@ruzell22 ruzell22 requested review from outSH and petermetz July 18, 2024 00:55
@jagpreetsinghsasan
Copy link
Contributor

LGTM

Primary Changes
---------------

1. Added word-wrap in resolutions in package.json

Fixes: hyperledger-cacti#2569

Signed-off-by: ruzell22 <[email protected]>
@petermetz petermetz merged commit ba703c7 into hyperledger-cacti:main Jul 18, 2024
143 checks passed
@petermetz petermetz deleted the wordwrap2569 branch July 18, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build(deps): persistently bump word-wrap from 1.2.3 to >=1.2.5
4 participants