ci(connector-xdai): fix docker rate limit issues with openethereum im… #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldousalvarez
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
outSH
approved these changes
Jul 29, 2024
petermetz
requested changes
Jul 31, 2024
There was a problem hiding this comment.
@aldousalvarez Could you please take a look at the failing xdai test cases?
aldousalvarez
force-pushed
the
aldousalvarez/issue3413
branch
from
c1b5f79 to
201b89e
Compare
|
@petermetz Already found which test was causing the issue. It is now fixed and the check is now passing for xdai |
petermetz
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
@aldousalvarez Great, thank you very much for the quick turnaround!
petermetz
force-pushed
the
aldousalvarez/issue3413
branch
from
201b89e to
30ce30c
Compare
…age pull Primary Changes ---------------- 1. Migrated all the xdai connector tests to besu ledger images that is being pulled from ghcr Fixes hyperledger-cacti#3413 Signed-off-by: aldousalvarez <[email protected]>
petermetz
force-pushed
the
aldousalvarez/issue3413
branch
from
30ce30c to
e76c367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
ci(connector-xdai): fix docker rate limit issues with openethereum image pull
Fixes #3413
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.