test(besu): refactor jest test negative test cases

[ashnashahgrover]

Commit to be reviewed

test(besu): refactor jest test negative test cases

1. Refactored all negative test case exception assertions for cactus-plugin-ledger-connector-besu.
Removed try-catch blocks, replaced with declarations through jest and jest-extended's own API.
2. Noted two tests within openapi-validation.test.ts
(GetPastLogsEndpoint and GetBesuRecordEndpointV1 with empty parameters) where the status
code returned should be 400 but is 200. This could be investigated in a seperate issue.

Fixes #3467

Pull Request Requirements

• Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
• Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
• Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

• Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
• Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

[outSH]

EDIT - Sorry, set wrong status by mistake :)

[outSH]

The test you've modified is failing in the CI, please investigate

[jagpreetsinghsasan]

@ashnashahgrover please fix the failing CI tests
PR - Commit Parity test is a new one which deals with checking if the PR description matches exactly to one of the included commit messages. I checked the diff and it seems that you have updated your commit message but havent updated the same in PR message. Updating the PR message/Commit message to match will fix this failing test.
Also did you test the code after refactoring (I cloned and tested this branch) ? This is must (also spend some time creating a clean PR with good PR-commit message, title, no unneccesary code, irrelevant code comments and all that general stuff)

[petermetz]

@ashnashahgrover Getting closer! I see that the lint is still failing, you could most likely fix that by running the lint locally and then committing the diff it generates.

[ashnashahgrover]

@ashnashahgrover Getting closer! I see that the lint is still failing, you could most likely fix that by running the lint locally and then committing the diff it generates.

Just did this, by running yarn run lint.

[outSH]

LGTM, thank you for the updates!

[petermetz]

@ashnashahgrover Looking good to me now. Tip for next time: Use the re-request review button to put it back in my review queue, otherwise it doesn't show up in my feed.

[jagpreetsinghsasan]

LGTM

Changes incorporated. Approved by Peter