Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): updated permissioning and versioning in GitHub Actions #3485

Merged
merged 1 commit into from
Aug 17, 2024
Merged

fix(ci): updated permissioning and versioning in GitHub Actions #3485

merged 1 commit into from
Aug 17, 2024

Conversation

VRamakrishna
Copy link
Contributor

@VRamakrishna VRamakrishna commented Aug 16, 2024

  • Fixes the failing deploy_docs.yaml action by adding token with appropriate permissioning.
  • Pegs the protoc-gen-go-grpc version in the relevant actions to v1.4.0 to match what's written in the documentation (this avoids test network setup failures when running integration tests.)
  • Removed dead code from the Weaver Corda sample application.
  • Made mkdocs publish URL customizable by owner.

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@VRamakrishna
Copy link
Contributor Author

FYI, I tested and the docs publish works in my fork.

@petermetz
Copy link
Contributor

@VRamakrishna Please include the full information you have in the PR description in the commit message as well!

This fixes the failing 'deploy_docs.yaml' action by adding token with appropriate permissioning.
It pegs the protoc-gen-go-grpc version in the relevant actions to v1.4.0
to match what's written in the documentation
(this avoids test network setup failures when running integration tests.)
Also removed dead code from the Weaver Corda sample application.
Made 'mkdocs' publish URL customizable by owner.

Signed-off-by: VRamakrishna <[email protected]>
@VRamakrishna
Copy link
Contributor Author

@petermetz Done.

@sandeepnRES sandeepnRES merged commit cd71082 into hyperledger-cacti:main Aug 17, 2024
142 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants