Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor jest test negative test cases - phase 1 #3488

Closed
wants to merge 1 commit into from
Closed

test: refactor jest test negative test cases - phase 1 #3488

wants to merge 1 commit into from

Conversation

ashnashahgrover
Copy link
Contributor

Commit to be reviewed

test: refactor jest test negative test cases - phase 1

Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes #3483

@ashnashahgrover
Copy link
Contributor Author

@jagpreetsinghsasan

Should I make a issue to investigate the inconsistencies in deploy-contract-from-json-xdai.test.ts and make this issue dependent on that?

petermetz
petermetz reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagpreetsinghsasan
Should I make a issue to investigate the inconsistencies in deploy-contract-from-json-xdai.test.ts and make this issue dependent on that?

@ashnashahgrover Yes please! It's looking good in general but we need to make sure the test assertions are working as intended (and if we found an underlying bug then first we have to fix those in order to be able to prove that the asesrtions themselves work as intended)

outSH
outSH requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only found one small things to fix

packages/cactus-verifier-client/src/test/typescript/unit/verifier-factory.test.ts Outdated Show resolved Hide resolved
@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue3483 branch from 947d28a to 44ebecf Compare August 26, 2024 20:40
@ashnashahgrover ashnashahgrover requested a review from outSH August 26, 2024 20:41
@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue3483 branch from 44ebecf to 31c3426 Compare August 26, 2024 21:08
outSH
outSH approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ashnashahgrover ashnashahgrover force-pushed the ashnashahgrover/issue3483 branch from 31c3426 to 69ce435 Compare September 21, 2024 00:44
@ashnashahgrover @petermetz
test: refactor jest test negative test cases - phase 1
af7dc0b 
Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages
Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes hyperledger-cacti#3483

Signed-off-by: ashnashahgrover <[email protected]>
@petermetz petermetz force-pushed the ashnashahgrover/issue3483 branch from 69ce435 to af7dc0b Compare October 15, 2024 00:03
@petermetz petermetz self-requested a review October 15, 2024 00:04
@petermetz
Copy link
Contributor

Closing this due to inactivity, please feel free to re-open anytime if/when bandwidth is available to take it to the finish line (some of the checks are failing such as the linter)

@petermetz petermetz closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outSH outSH outSH approved these changes

@petermetz petermetz petermetz approved these changes

@takeutak takeutak Awaiting requested review from takeutak takeutak is a code owner

@izuru0 izuru0 Awaiting requested review from izuru0 izuru0 is a code owner

@jagpreetsinghsasan jagpreetsinghsasan Awaiting requested review from jagpreetsinghsasan jagpreetsinghsasan is a code owner

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: refactor jest test negative test cases - phase 1
3 participants
@ashnashahgrover @petermetz @outSH