-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bungee-hermes): add BUNGEE package #3640
feat(bungee-hermes): add BUNGEE package #3640
Conversation
@petermetz are we good to merge this? |
@RafaelAPB Yes, good from my side. We need another reviewer as well though (another maintainer) |
Sure thing. Thanks for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just please divide PR dependencies into separate lines so that our bot can catch them, something like:
- Depends on feat(cactus-core-api): add Ethereum ledger type #3638
- Depends on feat(cactus-consortium): add Ethereum ledger type #3639
- Depends on feat(cactus-connector-besu): add RunTransactionV1Exchange to share receipt data #3642
- Depends on feat(cactus-connector-ethereum): add RunTransactionV1Exchange to share receipt data #3643
- Depends on feat(cactus-connector-fabric): add get transaction receipt by tx id #3644
🎉 All dependencies have been resolved ! |
Good point, thanks for catching that @outSH ! |
Thanks @outSH and @petermetz |
🎉 All dependencies have been resolved ! |
@RafaelAPB There are a few test failures, I'll take a quick look Edit: Sorry, ended up not having enough time to investigate it properly. |
4781fb1
to
80e3f98
Compare
BUNGEE is an implementation of a view generator https://dl.acm.org/doi/10.1145/3643689 Authored-by: Eduardo Vasques <[email protected]> Co-authored-by: Rafael Belchior <[email protected]> Signed-off-by: Rafael Belchior <[email protected]> fix(bungee-hermes): merge and process views tests Signed-off-by: Eduardo Vasques <[email protected]>
80e3f98
to
f378f44
Compare
I pushed a fix by @eduv09 - all should work now |
@RafaelAPB Nice, thank you, I'm merging it now! |
BUNGEE is an implementation of a view generator https://dl.acm.org/doi/10.1145/3643689
Depends on #3638 and #3639;: #3642, #3643 #3644
Depends on #3638
Depends on #3639
Depends on #3642
Depends on #3643
Depends on #3644
Authored-by: Eduardo Vasques [email protected]
Co-authored-by: Rafael Belchior [email protected]
Signed-off-by: Rafael Belchior [email protected]
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.