Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bungee-hermes): add BUNGEE package #3640

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

RafaelAPB
Copy link
Contributor

@RafaelAPB RafaelAPB commented Nov 15, 2024

BUNGEE is an implementation of a view generator https://dl.acm.org/doi/10.1145/3643689

Depends on #3638 and #3639;: #3642, #3643 #3644
Depends on #3638
Depends on #3639
Depends on #3642
Depends on #3643
Depends on #3644

Authored-by: Eduardo Vasques [email protected]
Co-authored-by: Rafael Belchior [email protected]
Signed-off-by: Rafael Belchior [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@RafaelAPB
Copy link
Contributor Author

@petermetz are we good to merge this?

@petermetz
Copy link
Contributor

@RafaelAPB Yes, good from my side. We need another reviewer as well though (another maintainer)

@RafaelAPB
Copy link
Contributor Author

Sure thing. Thanks for your review.

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

dpulls bot commented Nov 30, 2024

🎉 All dependencies have been resolved !

@github-actions github-actions bot removed the dependent label Dec 1, 2024
@petermetz
Copy link
Contributor

LGTM

Just please divide PR dependencies into separate lines so that our bot can catch them, something like:

* Depends on [feat(cactus-core-api): add Ethereum ledger type #3638](https://github.com/hyperledger-cacti/cacti/pull/3638)

* Depends on [feat(cactus-consortium): add Ethereum ledger type #3639](https://github.com/hyperledger-cacti/cacti/pull/3639)

* Depends on [feat(cactus-connector-besu): add RunTransactionV1Exchange to share receipt data #3642](https://github.com/hyperledger-cacti/cacti/pull/3642)

* Depends on [feat(cactus-connector-ethereum): add RunTransactionV1Exchange to share receipt data #3643](https://github.com/hyperledger-cacti/cacti/pull/3643)

* Depends on [feat(cactus-connector-fabric): add get transaction receipt by tx id #3644](https://github.com/hyperledger-cacti/cacti/pull/3644)

Good point, thanks for catching that @outSH !

@RafaelAPB
Copy link
Contributor Author

Thanks @outSH and @petermetz

Copy link

dpulls bot commented Dec 5, 2024

🎉 All dependencies have been resolved !

@github-actions github-actions bot removed the dependent label Dec 6, 2024
@petermetz
Copy link
Contributor

petermetz commented Dec 6, 2024

@RafaelAPB There are a few test failures, I'll take a quick look

Edit: Sorry, ended up not having enough time to investigate it properly.

@RafaelAPB RafaelAPB force-pushed the satp-dev-fixup-bungee branch from 4781fb1 to 80e3f98 Compare December 13, 2024 09:19
@RafaelAPB RafaelAPB requested a review from takeutak as a code owner December 13, 2024 09:19
BUNGEE is an implementation of a view generator https://dl.acm.org/doi/10.1145/3643689

Authored-by: Eduardo Vasques <[email protected]>
Co-authored-by: Rafael Belchior <[email protected]>
Signed-off-by: Rafael Belchior <[email protected]>

fix(bungee-hermes): merge and process views tests

Signed-off-by: Eduardo Vasques <[email protected]>
@RafaelAPB RafaelAPB force-pushed the satp-dev-fixup-bungee branch from 80e3f98 to f378f44 Compare December 13, 2024 15:30
@RafaelAPB
Copy link
Contributor Author

I pushed a fix by @eduv09 - all should work now

@petermetz
Copy link
Contributor

I pushed a fix by @eduv09 - all should work now

@RafaelAPB Nice, thank you, I'm merging it now!

@petermetz petermetz merged commit f378f44 into hyperledger-cacti:main Dec 14, 2024
134 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants