Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(satp-hermes): error handling and grpc upgrade to 2.0.0 and test fix #3673

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

LordKubaya
Copy link
Contributor

@LordKubaya LordKubaya commented Dec 6, 2024

  1. Enhanced Error Handling using Error.cause
    • Refactored error handling to improve code readability, maintainability, and reliability.
  2. Migration Improvements
    • Updated the migration process to ensure seamless compatibility with Connect version 2.0 (v2).
    • Fixed migration-related issues when upgrading to buf version 2.2.2.
  3. Testing Enhancements
    • Resolved an issue in the test file to allow individual tests to be executed independently for more effective debugging and validation.

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Signed-off-by: Carlos Amaro <[email protected]>

fix(satp-hermes): fix tests so you can test each test individually

Signed-off-by: Carlos Amaro <[email protected]>
@RafaelAPB RafaelAPB merged commit 7c16201 into hyperledger-cacti:satp-dev Dec 6, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants