Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(satp): make satp a cacti plugin #3677

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

eduv09
Copy link
Contributor

@eduv09 eduv09 commented Dec 6, 2024

  • changed cbdc example to use cacti api-server
  • added test to test the compatibility
  • TODO: check OAS (detailed comment in main plugin)

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

 * changed cbdc example to use cacti api-server
 * added test to test the compatibility
 * TODO: check OAS (detailed comment in main plugin)

Signed-off-by: Eduardo Vasques <[email protected]>
@RafaelAPB RafaelAPB merged commit ad241ba into hyperledger-cacti:satp-dev Dec 6, 2024
10 of 18 checks passed
@eduv09 eduv09 deleted the satp-w-api-server branch December 12, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants