fix(test): add knex config in gateway #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yogesh01000100
changed the title
Yogesh01000100
force-pushed
the
fix/satp-integration-tests
branch
2 times, most recently
from
d4c9087 to
d741bf9
Compare
Yogesh01000100
changed the title
LordKubaya
suggested changes
Dec 10, 2024
...s-plugin-satp-hermes/src/main/typescript/core/stage-services/client/stage0-client-service.ts
Outdated
Show resolved
Hide resolved
RafaelAPB
requested changes
Dec 10, 2024
...-satp-hermes/src/test/typescript/integration/satp-e2e-transfer-1-gateway-with-bungee.test.ts
Show resolved
Hide resolved
...ctus-plugin-satp-hermes/src/test/typescript/integration/satp-e2e-transfer-2-gateways.test.ts
Outdated
Show resolved
Hide resolved
Yogesh01000100
force-pushed
the
fix/satp-integration-tests
branch
from
d741bf9 to
f1203fa
Compare
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig Fixes hyperledger-cacti#3665 Signed-off-by: Yogesh01000100 <[email protected]>
Yogesh01000100
force-pushed
the
fix/satp-integration-tests
branch
from
f1203fa to
bb7328e
Compare
RafaelAPB
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig
Fixes #3665
Signed-off-by: Yogesh01000100 [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.