Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(satp-dev): spelling #3682

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

LordKubaya
Copy link
Contributor

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Signed-off-by: Carlos Amaro <[email protected]>
@LordKubaya LordKubaya requested a review from RafaelAPB as a code owner December 9, 2024 15:50
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LordKubaya LGTM, but please double check if this ends up being a breaking change of the API just to be sure.

It doesn't look like it would be (because nothing's changed in public-api.ts but wanted to make sure I highlight it.

@LordKubaya
Copy link
Contributor Author

@LordKubaya LGTM, but please double check if this ends up being a breaking change of the API just to be sure.

It doesn't look like it would be (because nothing's changed in public-api.ts but wanted to make sure I highlight it.

This is internal, nothing should affect the API.

@petermetz
Copy link
Contributor

@LordKubaya LGTM, but please double check if this ends up being a breaking change of the API just to be sure.
It doesn't look like it would be (because nothing's changed in public-api.ts but wanted to make sure I highlight it.

This is internal, nothing should affect the API.

@LordKubaya KK, thank you for taking the time to check on it!

@RafaelAPB RafaelAPB merged commit 947ec03 into hyperledger-cacti:satp-dev Dec 10, 2024
7 of 8 checks passed
@LordKubaya LordKubaya deleted the proto_error branch February 17, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants