fix(cbdc-example): support to the new satp-hermes version and fix some bugs #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LordKubaya
commented
Jan 7, 2025
•
LordKubaya
commented
- db configuration on cbdc-example
- fix versioning of the cbdc-example-backend in the cbdc-example-frontend
- add missing code to satp-hermes to check the last message of the protocol
- add test to the last check
- bug fixing
LordKubaya
requested review from
RafaelAPB,
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
LordKubaya
changed the title
fix(satp-hermes): session completion on client, missing test, missing implementation to check the last message Signed-off-by: Carlos Amaro <[email protected]>
LordKubaya
changed the title
LordKubaya
changed the title
RafaelAPB
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.