Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fabric-connector): add getDiscoveryResults endpoint #3727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Jan 17, 2025

  • Add getDiscoveryResults endpoint and connector method for reading structure of specified ledger channel.
  • Add baseline test to check the response from this endpoint.
  • Modify baseline test suite to work with already running ledger.
  • Fix small errors in comment in other parts of the code

Closes #3726

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

- Add getDiscoveryResults endpoint and connector method for reading
  structure of specified ledger channel.
- Add baseline test to check the response from this endpoint.
- Modify baseline test suite to work with already running ledger.
- Fix small errors in comment in other parts of the code

Closes hyperledger-cacti#3726

Signed-off-by: Michal Bajer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(fabric-connector): add getDiscoveryResults endpoint
1 participant