Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(validator): Go-ethereum validator and Fabric validator including execSyncFunctions #438

Merged
merged 1 commit into from
Dec 21, 2020
Merged

refactor(validator): Go-ethereum validator and Fabric validator including execSyncFunctions #438

merged 1 commit into from
Dec 21, 2020

Conversation

takeutak
Copy link
Contributor

@takeutak takeutak commented Dec 18, 2020 •
edited
Loading

This PR is related with Issue #302 , PR #417.
Signed-off-by: Takuma TAKEUCHI [email protected]

@takeutak takeutak changed the title refactor(validator): validators including execSyncFunctions refactor(validator): Go-ethereum validator and Fabric validator including execSyncFunctions Dec 18, 2020
@takeutak takeutak requested a review from sfuji822 December 18, 2020 15:51
@takeutak
Copy link
Contributor Author

takeutak commented Dec 18, 2020 •
edited
Loading

Contents:

  • (main) Updating validators for Go-Ethereum and Fabric
  • (sub) Updating car-trade sample app reflecting the above changing of the validators

How to use these codes:

  • NOTE: I changed the URL in the README to the one after merge due to the merging of pull-request.

@petermetz petermetz force-pushed the refactor_validators_execSyncFunctions branch from 0a17bf2 to deae3e4 Compare December 18, 2020 17:50
jonathan-m-hamilton
jonathan-m-hamilton approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takeutak takeutak merged commit db38cb5 into hyperledger-cacti:master Dec 21, 2020
@takeutak takeutak deleted the refactor_validators_execSyncFunctions branch December 21, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-m-hamilton jonathan-m-hamilton jonathan-m-hamilton approved these changes

@petermetz petermetz petermetz approved these changes

@sfuji822 sfuji822 Awaiting requested review from sfuji822

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takeutak @petermetz @jonathan-m-hamilton