Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tools): remove the duplicate wallet.tar #439

Merged
merged 1 commit into from
Jan 5, 2021
Merged

fix(tools): remove the duplicate wallet.tar #439

merged 1 commit into from
Jan 5, 2021

Conversation

takeutak
Copy link
Contributor

This PR is related with Issue #302

Signed-off-by: Takuma TAKEUCHI [email protected]

@takeutak takeutak requested a review from sfuji822 December 22, 2020 10:54
@takeutak
Copy link
Contributor Author

Contents:

  • remove the duplicate wallet because the same wallet directory already exists.

petermetz
petermetz approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonathan-m-hamilton
jonathan-m-hamilton approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takeutak takeutak merged commit fc7d707 into hyperledger-cacti:master Jan 5, 2021
@takeutak takeutak deleted the fix_tools_remove_the_duplicate_wallet_tar branch February 19, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-m-hamilton jonathan-m-hamilton jonathan-m-hamilton approved these changes

@petermetz petermetz petermetz approved these changes

@sfuji822 sfuji822 Awaiting requested review from sfuji822

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takeutak @petermetz @jonathan-m-hamilton