Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #4097: Fix warp noise in logs #4098

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Nov 29, 2023

Description

  • warp::trace::request() was attached twice for some endpoints, which lead to noise in logs
  • logging error inside queue push was redundant because error should be handled on caller site

Linked issue

Closes #4097

Benefits

Less noise in logs.

@Erigara Erigara added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Nov 29, 2023
@Erigara Erigara self-assigned this Nov 29, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7029291680

  • 5 of 7 (71.43%) changed or added relevant lines in 2 files are covered.
  • 7012 unchanged lines in 129 files lost coverage.
  • Overall coverage decreased (-3.1%) to 56.304%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cli/src/torii/routing.rs 0 1 0.0%
core/src/queue.rs 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.1%
Covered Lines: 23024
Relevant Lines: 40892

💛 - Coveralls

@DCNick3 DCNick3 self-assigned this Nov 29, 2023
@mversic mversic self-assigned this Nov 29, 2023
@mversic mversic requested a review from DCNick3 November 29, 2023 09:04
cli/src/torii/routing.rs Show resolved Hide resolved
@Erigara Erigara merged commit 7a6fe6b into hyperledger-iroha:iroha2-dev Nov 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants