Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: apply most recent clippy suggestions #4129

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Dec 8, 2023

Description

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 8, 2023
@mversic mversic force-pushed the clippy_suggestions branch 2 times, most recently from 5c0fbc6 to 68170cd Compare December 8, 2023 07:55
@coveralls
Copy link

coveralls commented Dec 8, 2023

Pull Request Test Coverage Report for Build 7140002651

  • 60 of 86 (69.77%) changed or added relevant lines in 23 files are covered.
  • 7009 unchanged lines in 129 files lost coverage.
  • Overall coverage decreased (-3.2%) to 56.28%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/gossiper.rs 0 1 0.0%
core/src/kura.rs 1 2 50.0%
core/src/query/cursor.rs 1 2 50.0%
core/src/smartcontracts/isi/triggers/set.rs 0 1 0.0%
core/src/snapshot.rs 0 1 0.0%
crypto/src/signature/bls/implementation.rs 4 5 80.0%
genesis/src/lib.rs 0 1 0.0%
smart_contract/executor/derive/src/entrypoint.rs 0 1 0.0%
smart_contract/src/lib.rs 0 1 0.0%
tools/wasm_test_runner/src/main.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.2%
Covered Lines: 23010
Relevant Lines: 40885

💛 - Coveralls

@mversic mversic self-assigned this Dec 8, 2023
@Arjentix Arjentix self-assigned this Dec 8, 2023
@DCNick3
Copy link
Contributor

DCNick3 commented Dec 8, 2023

Is this from clippy newer than the one we use in CI? If so, are there plans to update it in CI too?

Arjentix
Arjentix previously approved these changes Dec 8, 2023
Copy link
Contributor

@Arjentix Arjentix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update our CI to a new clippy verson?

@mversic
Copy link
Contributor Author

mversic commented Dec 8, 2023

Is this from clippy newer than the one we use in CI? If so, are there plans to update it in CI too?

this is in anticipation of update of rustc in CI. We'll do that soon

DCNick3
DCNick3 previously approved these changes Dec 8, 2023
@DCNick3 DCNick3 self-assigned this Dec 8, 2023
@mversic mversic force-pushed the clippy_suggestions branch 2 times, most recently from 2e959ca to d4952bf Compare December 8, 2023 09:10
6r1d
6r1d previously approved these changes Dec 8, 2023
@mversic mversic requested review from DCNick3 and Arjentix December 8, 2023 09:12
Arjentix
Arjentix previously approved these changes Dec 8, 2023
@mversic mversic dismissed stale reviews from Arjentix and 6r1d via ab35cd1 December 8, 2023 09:27
@mversic mversic force-pushed the clippy_suggestions branch 4 times, most recently from e2e9ba6 to d4ffae9 Compare December 8, 2023 09:50
@mversic mversic force-pushed the clippy_suggestions branch from d4ffae9 to 7f5b501 Compare December 8, 2023 10:06
@mversic mversic requested review from 6r1d and Arjentix December 8, 2023 10:30
@mversic mversic merged commit 6f2c04c into hyperledger-iroha:iroha2-dev Dec 8, 2023
11 checks passed
@mversic mversic deleted the clippy_suggestions branch December 8, 2023 11:11
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants