[ci] #4184: Bump to 2024-01-12 toolchain & Revert to custom Coveralls settings #4196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BAStos525
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara,
0x009922 and
DCNick3
as code owners
github-actions
bot
added
the
iroha2-dev
BAStos525
added
CI
and removed
iroha2-dev
|
please also update |
mversic
previously approved these changes
Jan 12, 2024
BAStos525
added
the
iroha2-dev
mversic
approved these changes
Jan 12, 2024
Arjentix
approved these changes
Jan 12, 2024
… custom Coveralls settings Signed-off-by: BAStos525 <[email protected]>
BAStos525
force-pushed
the
feature/DOPS-2943/i2-bump-toolchain-ver-revert-coveralls
branch
from
f076e6d to
0758f7a
Compare
BAStos525
deleted the
feature/DOPS-2943/i2-bump-toolchain-ver-revert-coveralls
branch
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Jan 22, 2024
… custom Coveralls settings (hyperledger-iroha#4196) [ci] hyperledger-iroha#4184: Bump to 2024-01-12 toolchain & revert to custom Coveralls settings Signed-off-by: BAStos525 <[email protected]> Signed-off-by: Asem-Abdelhady <[email protected]>
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Feb 9, 2024
… custom Coveralls settings (hyperledger-iroha#4196) [ci] hyperledger-iroha#4184: Bump to 2024-01-12 toolchain & revert to custom Coveralls settings Signed-off-by: BAStos525 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
iroha2ci-imageto the latest nightly toolchain (2024-01-12).ci-contaierin workflows tohyperledger/iroha2-ci:nightly-2024-01-12Linked issue
#4184 #4131
Benefits
IMPORTANT NOTE
Since we have updated the ci-image, WE MUST build and push it before the actual workflows will start to use it in CI. Previously we did it outside iroha repo (usually from forks) using the special HL DockerHub credentials that Hyperledger provided to us. Unfortunately, as Ry Jones told, they decided to remove these credentials since they can't continue to pay for that. Thus, we must to build and push the new ci-image asap when this PR will be merged.
UPD
Ry Jones decided to give us one more year for external HL DockerHub account. So, the new ci-image
has been already pushed from my fork.
Checklist
CONTRIBUTING.md