Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT]: make TransactionValue::error field public #4609

Merged
merged 1 commit into from
May 17, 2024
Merged

[BACKPORT]: make TransactionValue::error field public #4609

merged 1 commit into from
May 17, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented May 17, 2024 •
edited
Loading

Description

Closes #4561

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@mversic mversic enabled auto-merge (squash) May 17, 2024 05:39
@mversic mversic changed the title [fix]: make TransactionValue::error field public [BACKPORT]: make TransactionValue::error field public May 17, 2024
@nxsaken nxsaken removed the iroha2 label May 17, 2024
@mversic mversic merged commit 9dc9b23 into hyperledger-iroha:stable May 17, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxsaken nxsaken nxsaken approved these changes

@DCNick3 DCNick3 DCNick3 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@QuentinI QuentinI Awaiting requested review from QuentinI

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@ilchu ilchu Awaiting requested review from ilchu

@pesterev pesterev Awaiting requested review from pesterev

@Erigara Erigara Awaiting requested review from Erigara

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mversic @DCNick3 @nxsaken