Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove TriggeringEventFilterBox #4866

Merged
merged 1 commit into from
Jul 24, 2024
Merged

refactor: remove TriggeringEventFilterBox #4866

merged 1 commit into from
Jul 24, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Jul 19, 2024

Description

I love static typing. It prevents many errors.
But there is a tradeoff between static typing and an API that is easy to use.
Sometimes too much static typing is difficult for end users

Linked issue

Closes #4376

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Jul 19, 2024
@mversic mversic force-pushed the remove_triggering_event_filter_box branch 4 times, most recently from a41865b to a824afd Compare July 22, 2024 08:07
Erigara
Erigara reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still not sure why we should treat trigger completion event separately.

It was requested like that in #2885, but reasons are not specified.

core/src/smartcontracts/isi/triggers/mod.rs Show resolved Hide resolved
@Erigara
Copy link
Contributor

Erigara commented Jul 22, 2024

In general i agree that strict typing in this case create more inconvenience than value.

@mversic mversic mentioned this pull request Jul 22, 2024
Open
@mversic mversic force-pushed the remove_triggering_event_filter_box branch from a824afd to ec25f64 Compare July 22, 2024 14:42
0x009922
0x009922 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good tradeoff.

data_model/src/trigger.rs Show resolved Hide resolved
@mversic mversic force-pushed the remove_triggering_event_filter_box branch from ec25f64 to 3bb0b8c Compare July 23, 2024 21:12
@mversic mversic enabled auto-merge (squash) July 23, 2024 21:13
@Erigara Erigara force-pushed the remove_triggering_event_filter_box branch from 3bb0b8c to 015e030 Compare July 24, 2024 07:57
@mversic mversic mentioned this pull request Jul 24, 2024
Open
@mversic mversic force-pushed the remove_triggering_event_filter_box branch from 015e030 to ed886e6 Compare July 24, 2024 09:40
@mversic mversic merged commit 2dec013 into hyperledger-iroha:main Jul 24, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x009922 0x009922 0x009922 approved these changes

@Erigara Erigara Erigara approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@Erigara Erigara

@0x009922 0x009922

@mversic mversic

Labels
api-changes Changes in the API for client libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we remove TriggeringEventFilterBox?
3 participants
@mversic @Erigara @0x009922