New CarbonTracker contract and TokenTypeId (4) for NET network #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a first attempt to address issue372. I have modified the original NetEmissionTokenNetwork.sol contract (not sure if or how we should implement this as a contract upgrade). Modified the token-network tests for the new token type Id =4. Started building tests for new CarbonTracker contract. Preparing detailed documentation and examples. The new CarbonTracker NFTs could be integrated with the Fabric emission audit system. Audited emission tokens could be issued as partial outputs of each NFT. |
brioux
force-pushed
the
CarbonTracker
branch
5 times, most recently
from
ef7badd to
a55aa8a
Compare
|
This pull request introduces 1 alert when merging a55aa8a into d979c3e - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 5c67e01 into d979c3e - view on LGTM.com new alerts:
|
TokenTypeId=4 for carbon Tokens issued (voluntarily) by registered industry of the Net Emission Token (NET) Network. This supply side token and CarbonTracker contract will enable shared emission inventories across organizations and embedded emission tracking. Short summary of the CarbonTracker contract features: - a NFT using ERC721Upgradeable template create carbon trackers - Each NFT is used to track the unique emission profile of a product/facility based on NETs - NETs in each NFTs can be linked to previous NFT connect emission profiles (embedded emissions) Major additions/changes to the NetEmissionTokenNetwork contract: - update _beforeTokenTransfer hook consumerOrDealer modifier for from/to addresses - Applies modifier to super.safeTransfer/super._mint/super._burn - If tokenTypeId == 4 require receiverApproved before sending tokens Signed-off-by: brioux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokenTypeId=4 for carbon Tokens issued (voluntarily) by registered industry of the Net Emission Token (NET) Network. This supply side token and CarbonTracker contract will enable shared emission inventories across organizations and embedded emission tracking.
Short summary of the CarbonTracker contract features:
Major additions/changes to the NetEmissionTokenNetwork contract:
Signed-off-by: brioux [email protected]