Merge pull request #771 from boschresearch/fix/legacy-peer-deps

add --legacy-peer-deps flag to all pipelines
hyperledger-labs · Jun 23, 2022 · 0e558ff · 0e558ff
2 parents 6a056cc + fc52229
commit 0e558ff
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 35 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -28,9 +28,9 @@ jobs:
       - name: Setup node and install deps
         uses: actions/setup-node@v2
         with:
-          node-version: '16.15.0'
-          check-latest: false
-      - run: npm --prefix frontend ci --no-optional
+          node-version: '16'
+          check-latest: true
+      - run: npm --prefix frontend ci --legacy-peer-deps
 
       - name: Setup Java
         uses: actions/setup-java@v2

diff --git a/Dockerfile b/Dockerfile
@@ -1,10 +1,10 @@
 # Dockerfile that builds frontend and backend, mainly used by the docker-compose files
 
 # Vue Build Container
-FROM node:16-alpine3.13 as VUE
+FROM node:16-buster as VUE
 WORKDIR /frontend
 COPY frontend .
-RUN npm install && npm run build
+RUN npm ci --legacy-peer-deps && npm run build
 
 # Micronaut build
 FROM maven:3-eclipse-temurin-17 as MAVEN

diff --git a/backend/business-partner-agent/pom.xml b/backend/business-partner-agent/pom.xml
@@ -417,8 +417,8 @@
                                 </goals>
                                 <configuration>
                                     <!-- See https://nodejs.org/en/download/ -->
-                                    <nodeVersion>v16.15.0</nodeVersion>
-                                    <npmVersion>8.5.5</npmVersion>
+                                    <nodeVersion>v16.15.1</nodeVersion>
+                                    <npmVersion>8.11.0</npmVersion>
                                 </configuration>
                             </execution>
                             <execution>
@@ -428,7 +428,7 @@
                                     <goal>npm</goal>
                                 </goals>
                                 <configuration>
-                                    <arguments>ci --no-optional</arguments>
+                                    <arguments>ci --legacy-peer-deps</arguments>
                                 </configuration>
                             </execution>
                             <execution>

diff --git a/frontend/.npmrc b/frontend/.npmrc
@@ -4,4 +4,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 save-exact=true
-optional=false
+save-prefix=
+omit[]=optional
+legacy-peer-deps=true
diff --git a/frontend/package-lock.json b/frontend/package-lock.json