Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

wasm binary generation for unit test #25

Open
kleash opened this issue Oct 12, 2019 · 9 comments
Open

wasm binary generation for unit test #25

kleash opened this issue Oct 12, 2019 · 9 comments

Comments

@kleash
Copy link
Contributor

kleash commented Oct 12, 2019

Use makefile to generate wasm binary for unit testing

@kleash
Copy link
Contributor Author

kleash commented Nov 14, 2019

Should we remove wasm binary from repo and add it as part of make file for unit test and integration test?

@MHBauer
Copy link
Contributor

MHBauer commented Nov 14, 2019

If we can achieve that in the CI, it would help enforce the reproducibility of the repository.

Given how small these are, and that they're already in the repo, it's not going to save us any space.

I am in favor of the idea.

@MHBauer
Copy link
Contributor

MHBauer commented Nov 14, 2019

Did you want to do this work, or merge #24?

@kleash
Copy link
Contributor Author

kleash commented Nov 14, 2019

The only problem I see in removing wasm binaries from repo is, we need these binaries for running unit tests, and it takes an awful lot of time to compile and generate rust chaincode to wasm. Ignoring the fact that the user has to also install rust/c tools for generating this wasm binary for running wasmcc unit tests alone.

@kleash
Copy link
Contributor Author

kleash commented Nov 14, 2019

How about, using Git Actions to publish wasm binaries under GitHub Packages.

And, make can curl download these GitHub packages for unit tests.

@kleash
Copy link
Contributor Author

kleash commented Nov 19, 2019

In the last discussion, we were planning to build wasm binary as part of our CI and push it to the repository.

But that might result in a very bulky repository because it will add binary files in every PR.

Thoughts?

@MHBauer
Copy link
Contributor

MHBauer commented Nov 19, 2019

I do not understand how it adds it to every pr.
Binary push can be done pseudo outside of the repo by pushing to the repository "releases".
https://help.github.com/en/github/administering-a-repository/creating-releases

@kleash
Copy link
Contributor Author

kleash commented Nov 22, 2019

So should we publish both rust and C generated wasm binaries to releases?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants