Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

link fixes in documentation after migration #23

Merged
merged 2 commits into from
Oct 12, 2019

Conversation

kleash
Copy link
Contributor

@kleash kleash commented Oct 10, 2019

  • Links changed to relative path instead of absolute
  • Readme format fix

Signed-off-by: Shubham Aggarwal [email protected]

Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message should say something like

  • use repo-relative linking
  • use single backtick instead of triple backtick for inline verbatim text.

README.md Outdated Show resolved Hide resolved
- use repo-relative linking
- use single backtick instead of triple backtick for inline verbatim text

Signed-off-by: Shubham Aggarwal <[email protected]>
@kleash kleash force-pushed the migration_link_fixes branch from 832f51a to d414a9d Compare October 11, 2019 06:57
@kleash
Copy link
Contributor Author

kleash commented Oct 11, 2019

commit message should say something like

  • use repo-relative linking
  • use single backtick instead of triple backtick for inline verbatim text.

fixed

@kleash kleash closed this Oct 11, 2019
@kleash kleash reopened this Oct 11, 2019
@kleash kleash requested a review from MHBauer October 11, 2019 06:58
Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Give command ```go test```
- Compile sample rust chaincode at `sample-wasm-chaincode/chaincode_example02/rust/src/lib.rs` to wasm binary : [instructions](sample-wasm-chaincode/README.md)
- Go to `wasmcc` directory
- Give command `go test`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a TODO for later. should attempt to refer to the makefile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MHBauer good point. opened an issue here for same: #25

@kleash kleash merged commit d5b1062 into hyperledger-labs:master Oct 12, 2019
@kleash kleash deleted the migration_link_fixes branch October 12, 2019 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants