This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
link fixes in documentation after migration #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHBauer
reviewed
Oct 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit message should say something like
- use repo-relative linking
- use single backtick instead of triple backtick for inline verbatim text.
- use repo-relative linking - use single backtick instead of triple backtick for inline verbatim text Signed-off-by: Shubham Aggarwal <[email protected]>
kleash
force-pushed
the
migration_link_fixes
branch
from
October 11, 2019 06:57
832f51a
to
d414a9d
Compare
fixed |
MHBauer
approved these changes
Oct 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Give command ```go test``` | ||
- Compile sample rust chaincode at `sample-wasm-chaincode/chaincode_example02/rust/src/lib.rs` to wasm binary : [instructions](sample-wasm-chaincode/README.md) | ||
- Go to `wasmcc` directory | ||
- Give command `go test` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a TODO for later. should attempt to refer to the makefile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham Aggarwal [email protected]