Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added traces #620

Closed
wants to merge 52 commits into from
Closed

Added traces #620

wants to merge 52 commits into from

Conversation

alexandrosfilios
Copy link
Contributor

No description provided.

adecaro
adecaro approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@adecaro adecaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please, check the comments though.

platform/view/sdk/dig/sdk.go
@@ -121,7 +121,7 @@ func (p *SDK) Install() error {
p.C.Provide(operations.NewOperationSystem),
p.C.Provide(view3.NewResponseMarshaler, dig.As(new(view3.Marshaller))),
p.C.Provide(func(o *operations.Options, l operations.OperationsLogger) metrics2.Provider {
return operations.NewMetricsProvider(o.Metrics, l, false)
return operations.NewMetricsProvider(o.Metrics, l, true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why skipping the error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it happens to register the same metric multiple times. It should just ignore it and skip the double registration.

platform/view/services/tracing/span.go
return time.Now()
}
return t
//if t.IsZero() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forget something here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is never the case so far, but yes I should fix this

@alexandrosfilios
Fixed multiplexed provider
f772bf8 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios alexandrosfilios force-pushed the fix-duration-metrics branch 2 times, most recently from 1667315 to e675c41 Compare July 15, 2024 05:03
alexandrosfilios and others added 18 commits July 15, 2024 13:45
@alexandrosfilios
Added traces in communication
975ef89 
Signed-off-by: Alexandros Filios <[email protected]>
@adecaro @alexandrosfilios
dispose sessions and contexts
0fc32ad 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! dispose sessions and contexts
a621234 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! dispose sessions and contexts
22327d6 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! dispose sessions and contexts
87abe21 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! dispose sessions and contexts
3dde66a 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! dispose sessions and contexts
699e6d0 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! dispose sessions and contexts
b53fda6 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! dispose sessions and contexts
7abdc55 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! dispose sessions and contexts
cc3cdd0 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! dispose sessions and contexts
da10c97 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! dispose sessions and contexts
57b2830 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
delete streams on node
ef68d85 
fix info hash

Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
don't panic when the stream is not found
0971433 
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
@adecaro @alexandrosfilios
fixup! don't panic when the stream is not found
b852616 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! don't panic when the stream is not found
bdc878e 
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro @alexandrosfilios
fixup! don't panic when the stream is not found
8e6f6f9 
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
@adecaro @alexandrosfilios
remove the right stream
58e4757 
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
alexandrosfilios and others added 28 commits July 15, 2024 15:23
@alexandrosfilios
Added multiplexed provider
d546592 
Signed-off-by: Alexandros Filios <[email protected]>
@adecaro @alexandrosfilios
close a stream only after no session is using it
d0fc76b 
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
edafc9c 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
732e192 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
2f987fa 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
ac20fd3 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
4fbf8ab 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
c98bce0 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
bdf7cb7 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
e3be3cb 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
979b8bd 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
8a1efc1 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
553bee1 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
88d8460 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
a100d12 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
6465ffb 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Revert "Added multiplexed provider"
e00f3de 
This reverts commit 6465ffb.
@alexandrosfilios
Revert "Added multiplexed provider"
05677ce 
This reverts commit a100d12.
@alexandrosfilios
Revert "Added multiplexed provider"
08640c4 
This reverts commit 88d8460.
@alexandrosfilios
Revert "Added multiplexed provider"
3663fff 
This reverts commit 553bee1.
@alexandrosfilios
Added multiplexed provider
2e7d913 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
fa422bc 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added multiplexed provider
586c964 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added GetOrLoad method in second chance cache
afda1b9 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Decorator to disable histograms
d57eb8c 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added permutation iterator that share the same slice of data
2013520 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Added permutation iterator that share the same slice of data
c8e3f99 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios
Extracted network/channel config provider
7c5b18e 
Signed-off-by: Alexandros Filios <[email protected]>
@alexandrosfilios alexandrosfilios deleted the fix-duration-metrics branch July 18, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecaro adecaro adecaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandrosfilios @adecaro