-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added traces #620
Added traces #620
Conversation
4c883bc
to
c983b2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please, check the comments though.
@@ -121,7 +121,7 @@ func (p *SDK) Install() error { | |||
p.C.Provide(operations.NewOperationSystem), | |||
p.C.Provide(view3.NewResponseMarshaler, dig.As(new(view3.Marshaller))), | |||
p.C.Provide(func(o *operations.Options, l operations.OperationsLogger) metrics2.Provider { | |||
return operations.NewMetricsProvider(o.Metrics, l, false) | |||
return operations.NewMetricsProvider(o.Metrics, l, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why skipping the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it happens to register the same metric multiple times. It should just ignore it and skip the double registration.
return time.Now() | ||
} | ||
return t | ||
//if t.IsZero() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forget something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is never the case so far, but yes I should fix this
bbf3db3
to
0827798
Compare
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
12368f7
to
526b77f
Compare
Signed-off-by: Alexandros Filios <[email protected]>
1667315
to
e675c41
Compare
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
fix info hash Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]> Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]> Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]> Signed-off-by: Alexandros Filios <[email protected]>
e0cca58
to
58e4757
Compare
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]> Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
This reverts commit 6465ffb.
This reverts commit a100d12.
This reverts commit 88d8460.
This reverts commit 553bee1.
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
No description provided.