Remove signature metadata action #358
Conversation
token/core/fabtoken/actions.go
Outdated
| @@ -189,6 +189,6 @@ func (t *TransferAction) Deserialize(raw []byte) error { | |||
| } | |||
|
|
|||
| // GetMetadata returns the claim pre-image | |||
There was a problem hiding this comment.
Please change this comment
| @@ -207,8 +210,8 @@ func (t *TransferAction) IsGraphHiding() bool { | |||
|
|
|||
| // GetMetadata returns metadata of the TransferAction | |||
| // in zkatdlog it returns the claim pre-image | |||
There was a problem hiding this comment.
Please change comment
| IsGraphHiding() bool | ||
| GetMetadata() []byte | ||
| // GetMetadata returns the action's metadata |
There was a problem hiding this comment.
Add a dot at the end of the comment?
There was a problem hiding this comment.
I think we usually don't have it. No?
| if logger.IsEnabledFor(zapcore.DebugLevel) { | ||
| logger.Debugf("expected key without the claim pre-image, skipping") | ||
| logger.Debugf("expected key without the issue action metadata, skipping") |
Signed-off-by: Hagar Meir <[email protected]>
Signed-off-by: Hagar Meir <[email protected]>
Signed-off-by: Hagar Meir <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
token/services/vault/keys/keys.go
Outdated
| @@ -41,6 +41,7 @@ const ( | |||
| SerialNumber = "sn" | |||
| IssueActionMetadata = "iam" | |||
| TransferActionMetadata = "tam" | |||
| ClaimPreImage = "cpi" | |||
There was a problem hiding this comment.
I think you can remove this?
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
| } | ||
| // is it owned by a htlc script? | ||
| if owner.Type == htlc.ScriptType { | ||
| // Then, the first output must be compatible with this input. |
There was a problem hiding this comment.
the transfer action should include one output.
There was a problem hiding this comment.
not sure about this. What should I change?
| return errors.Errorf("invalid transfer action: an htlc script only transfers the ownership of a token") | ||
| } | ||
|
|
||
| // check type and quantity |
There was a problem hiding this comment.
for an ownership transfer
There was a problem hiding this comment.
can you specify the full error message, please?
Signed-off-by: Angelo De Caro <[email protected]>
| } | ||
|
|
||
| out := ctx.Action.GetOutputs()[0].(*token.Token) | ||
| if ctx.InputTokens[0].Data.Equals(out.Data) { |
There was a problem hiding this comment.
This check should be removed as it is incorrect. ZKVerifier takes care of checking if the transfer of ownership is correct.
There was a problem hiding this comment.
where is this check done exactly?
Signed-off-by: Hagar Meir <[email protected]>
Signed-off-by: Hagar Meir <[email protected]>
Signed-off-by: Hagar Meir [email protected]