Feat multiple backends #1165
sophia1chAnnotations
10 errors and 16 warnings
|
Vetting:
channel/test/randomizer.go#L152
File is not `gofmt`-ed with `-s` (gofmt)
|
|
Vetting:
channel/allocation_test.go#L281
File is not `gofmt`-ed with `-s` (gofmt)
|
|
Vetting:
channel/persistence/nonpersister.go#L39
File is not `gofumpt`-ed (gofumpt)
|
|
Vetting:
channel/params.go#L120
File is not `gofumpt`-ed (gofumpt)
|
|
Vetting:
channel/params.go#L308
File is not `gofumpt`-ed (gofumpt)
|
|
Vetting:
channel/persistence/test/peerchans.go#L93
avoid allocations with bytes.NewBufferString (mirror)
|
|
Vetting:
wire/net/simple/address.go#L184
avoid allocations with strings.Compare (mirror)
|
|
Vetting:
wire/net/simple/address.go#L189
avoid allocations with strings.Compare (mirror)
|
|
Vetting:
channel/persistence/keyvalue/restorer.go#L74
avoid allocations with bytes.NewBufferString (mirror)
|
|
Vetting:
wire/address.go#L184
Consider pre-allocating `indexes` (prealloc)
|
|
Tests
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use the latest version of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/
|
|
Race Tests
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use the latest version of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/
|
|
Copyright
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Race Tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Vetting
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Vetting:
wallet/address.go#L52
exported: exported method BackendID.Equal should have comment or be unexported (revive)
|
|
Vetting:
wallet/address.go#L70
exported: comment on exported function IndexOfAddrs should be of the form "IndexOfAddrs ..." (revive)
|
|
Vetting:
wallet/backend.go#L67
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
|
Vetting:
wallet/test/randomizer.go#L73
exported: comment on exported function NewRandomAddresses should be of the form "NewRandomAddresses ..." (revive)
|
|
Vetting:
wallet/test/randomizer.go#L129
exported: comment on exported function NewRandomAddressArray should be of the form "NewRandomAddressArray ..." (revive)
|
|
Vetting:
wallet/test/randomizer.go#L138
exported: comment on exported function NewRandomAddressesMap should be of the form "NewRandomAddressesMap ..." (revive)
|
|
Vetting:
wire/perunio/string_internal_test.go#L36
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Vetting:
wire/perunio/string_internal_test.go#L56
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Vetting:
wire/test/bustest.go#L76
unused-parameter: parameter 'e' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Vetting:
channel/multi/adjudicator.go#L53
var-naming: var assetIds should be assetIDs (revive)
|