chore(all): remove unnecessary flags

Signed-off-by: Sophia Koehler <[email protected]>
hyperledger-labs · Dec 19, 2024 · ced8fb5 · ced8fb5
1 parent 2c079f1
commit ced8fb5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/apps/payment/app_internal_test.go b/apps/payment/app_internal_test.go
@@ -95,7 +95,7 @@ func TestApp_ValidTransition(t *testing.T) {
 			numParticipants := len(tt.from[0])
 			for i := 0; i < numParticipants; i++ {
 				// valid self-transition
-				assert.NoError(app.ValidTransition(nil, from, from, channel.Index(i))) //nolint:gosec
+				assert.NoError(app.ValidTransition(nil, from, from, channel.Index(i)))
 			}
 
 			for _, tto := range tt.tos {
@@ -105,7 +105,7 @@ func TestApp_ValidTransition(t *testing.T) {
 					test.WithBalances(asBalances(tto.alloc...)...),
 				)
 				for i := 0; i < numParticipants; i++ {
-					err := app.ValidTransition(nil, from, to, channel.Index(i)) //nolint:gosec
+					err := app.ValidTransition(nil, from, to, channel.Index(i))
 					if i == tto.valid {
 						assert.NoError(err)
 					} else {

diff --git a/channel/persistence/statemachine_test.go b/channel/persistence/statemachine_test.go
@@ -76,7 +76,7 @@ func TestStateMachine(t *testing.T) {
 				sig, err = channel.Sign(acc, csm.StagingState(), b)
 				require.NoError(err)
 			}
-			err = sm.AddSig(ctx, channel.Index(i), sig) //nolint:gosec
+			err = sm.AddSig(ctx, channel.Index(i), sig)
 			require.NoError(err)
 			tpr.AssertEqual(csm)
 		}
@@ -152,7 +152,7 @@ func TestStateMachine(t *testing.T) {
 
 	// Set Progressed
 	timeout := ctest.NewRandomTimeout(rng)
-	idx := channel.Index(rng.Intn(s.NumParts())) //nolint:gosec
+	idx := channel.Index(rng.Intn(s.NumParts()))
 	e := channel.NewProgressedEvent(s.ID[0], timeout, s, idx)
 	err = sm.SetProgressed(ctx, e)
 	require.NoError(err)

diff --git a/client/restore_internal_test.go b/client/restore_internal_test.go
@@ -120,7 +120,7 @@ func mkRndChan(rng *rand.Rand, bID wallet.BackendID) *persistence.Channel {
 		parts[i] = map[wallet.BackendID]wallet.Address{bID: wallettest.NewRandomAccount(rng, bID).Address()}
 	}
 	ch := persistence.NewChannel()
-	ch.IdxV = channel.Index(rng.Intn(channel.MaxNumParts)) //nolint:gosec
+	ch.IdxV = channel.Index(rng.Intn(channel.MaxNumParts))
 	ch.ParamsV = test.NewRandomParams(rng, test.WithParts(parts))
 	sigs := make([]bool, channel.MaxNumParts)
 	opts := test.WithParams(ch.ParamsV)

diff --git a/watcher/local/watcher_test.go b/watcher/local/watcher_test.go
@@ -735,7 +735,7 @@ func randomTxsForSingleCh(rng *rand.Rand, n int) (*channel.Params, []channel.Tra
 	txs := make([]channel.Transaction, n)
 	for i := range txs {
 		txs[i] = channel.Transaction{State: initialState.Clone()}
-		txs[i].State.Version = uint64(i) //nolint:gosec
+		txs[i].State.Version = uint64(i)
 	}
 	return params, txs
 }