-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert: Remove settle secondary (#351) #400
Merged
iljabvh
merged 9 commits into
hyperledger-labs:main
from
perun-network:feat-secondary-settle
Feb 20, 2024
Merged
Revert: Remove settle secondary (#351) #400
iljabvh
merged 9 commits into
hyperledger-labs:main
from
perun-network:feat-secondary-settle
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows including `wire.proto` in other projects and generates the correct include paths in .proto modules including it. Signed-off-by: Steffen Rattay <[email protected]>
Signed-off-by: Steffen Rattay <[email protected]>
…tories Signed-off-by: Ilja von Hoessle <[email protected]>
Signed-off-by: Ilja von Hoessle <[email protected]>
Signed-off-by: Ilja von Hoessle <[email protected]>
Signed-off-by: Minh Huy Tran <[email protected]>
…perun types Signed-off-by: Jan Bormet <[email protected]>
sophia1ch
force-pushed
the
feat-secondary-settle
branch
from
February 20, 2024 13:56
bfc51ff
to
f40c671
Compare
Chore: Add author for this commit. Signed-off-by: Sophia Koehler <[email protected]> chore: update NOTICE. Signed-off-by: Sophia Koehler <[email protected]>
sophia1ch
force-pushed
the
feat-secondary-settle
branch
from
February 20, 2024 15:10
15e04a6
to
35ed061
Compare
Signed-off-by: Sophia <[email protected]>
iljabvh
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR restores the option to wait for the peer to call concludeFinal first. It is compatible with the Eth-Backend that has this option reactivated as well, found here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is linked to hyperledger-labs/perun-eth-backend#47 and reverts commit be6e072.