feat(wallet-sdk, core-ledger-client): earn app rewards for deposits #685
+491
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiersi-da
reviewed
Oct 15, 2025
| contractId: proxyCid, | ||
| choice: 'DelegateProxy_TransferInstruction_Reject', | ||
| choiceArgument: choiceArgs, | ||
| }, |
There was a problem hiding this comment.
@rukmini-basu-da @PHOL-DA : any particular reason that you are not leveraging the codegen's types for constructing this command?
There was a problem hiding this comment.
I think we have this issue that will allow us to use the codegen's types
PHOL-DA
reviewed
Oct 16, 2025
docs/wallet-integration-guide/examples/scripts/14-rewards-for-deposits.ts
Outdated
Show resolved
Hide resolved
docs/wallet-integration-guide/examples/scripts/14-rewards-for-deposits.ts
Outdated
Show resolved
Hide resolved
docs/wallet-integration-guide/examples/scripts/14-rewards-for-deposits.ts
Outdated
Show resolved
Hide resolved
docs/wallet-integration-guide/examples/scripts/14-rewards-for-deposits.ts
Outdated
Show resolved
Hide resolved
docs/wallet-integration-guide/examples/scripts/14-rewards-for-deposits.ts
Outdated
Show resolved
Hide resolved
docs/wallet-integration-guide/examples/scripts/14-rewards-for-deposits.ts
Outdated
Show resolved
Hide resolved
rukmini-basu-da
force-pushed
the
rukmini/rewards-for-deposits
branch
from
2db3736 to
044aecc
Compare
Signed-off-by: rukmini-basu-da <[email protected]>
Signed-off-by: rukmini-basu-da <[email protected]>
…erInstruction_Withdraw Signed-off-by: rukmini-basu-da <[email protected]>
Signed-off-by: rukmini-basu-da <[email protected]>
Signed-off-by: rukmini-basu-da <[email protected]>
…deposits.ts Co-authored-by: Phillip Olesen <[email protected]> Signed-off-by: rukmini-basu-da <[email protected]>
Co-authored-by: Phillip Olesen <[email protected]> Signed-off-by: rukmini-basu-da <[email protected]>
Signed-off-by: rukmini-basu-da <[email protected]>
Signed-off-by: rukmini-basu-da <[email protected]>
Signed-off-by: rukmini-basu-da <[email protected]>
Signed-off-by: rukmini-basu-da <[email protected]>
rukmini-basu-da
force-pushed
the
rukmini/rewards-for-deposits
branch
from
d582be2 to
874694b
Compare
Signed-off-by: rukmini-basu-da <[email protected]>
Signed-off-by: rukmini-basu-da <[email protected]>
Signed-off-by: rukmini-basu-da <[email protected]>
Signed-off-by: rukmini-basu-da <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #492