Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC-8: Fix missing checks on revision_number #310

Draft
wants to merge 5 commits into
base: audit-202409
Choose a base branch
from

Conversation

bluele
Copy link
Member

@bluele bluele commented Nov 25, 2024

No description provided.

@bluele bluele added the audit label Nov 25, 2024
@bluele bluele force-pushed the audit-202409-ibc-8 branch 4 times, most recently from 4319f7e to 08c0139 Compare November 26, 2024 01:48
@siburu
Copy link
Contributor

siburu commented Nov 26, 2024

@bluele In many files under the contracts/clients directory, revision_number is initialized to or compared to hardcoded 0s.
Shouldn't these 0s be replaced with DEFAULT_REVISION_NUMBER?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants