Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to new hyperledger-solang org #1668

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Move to new hyperledger-solang org #1668

merged 1 commit into from
Sep 30, 2024

Conversation

seanyoung
Copy link
Contributor

@seanyoung seanyoung commented Sep 27, 2024 •
edited
Loading

@ryjones
Copy link
Contributor

ryjones commented Sep 27, 2024

You can probably remove .github/workflows/dco.yml - the new DCO bot is run by CNCF and is more stable.

@seanyoung seanyoung marked this pull request as ready for review September 30, 2024 10:02
@seanyoung
Copy link
Contributor Author

@ryjones DCO is preventing merge after I removed .github/workflows/dco.yml

@ryjones
Copy link
Contributor

ryjones commented Sep 30, 2024

@seanyoung I don't see that - it looks like it passed to me?

@ryjones ryjones enabled auto-merge (rebase) September 30, 2024 15:25
@seanyoung
Copy link
Contributor Author

See below:
image

@ryjones
Copy link
Contributor

ryjones commented Sep 30, 2024

found it

ryjones
ryjones approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ryjones ryjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryjones ryjones merged commit 5176166 into hyperledger-solang:main Sep 30, 2024
18 checks passed
@seanyoung seanyoung deleted the new-org branch September 30, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryjones ryjones ryjones approved these changes

@xermicus xermicus Awaiting requested review from xermicus xermicus is a code owner

@salaheldinsoliman salaheldinsoliman Awaiting requested review from salaheldinsoliman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanyoung @ryjones