Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/soroban uint32 #1691

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ahmadsamehh
Copy link

Added support type uint32 for Soroban.

@ahmadsamehh ahmadsamehh marked this pull request as ready for review February 8, 2025 18:47
@salaheldinsoliman
Copy link
Contributor

salaheldinsoliman commented Feb 8, 2025

Please remove:
1- node_modules
2- any .wasm and .abi files
3- test_snapshots
4- Any files related to npm in the root directory
5- DS_StORE

Also:
Changes for this feature should only be in integration/soroban, src/codegen. Any other changes are residuals from your local setup and don't belong to the PR.

Copy link
Contributor

@salaheldinsoliman salaheldinsoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cleanup of residual files is needed first before a review can done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants