abi.decode("", ()) has no returns #1732
Merged
+40
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanyoung
force-pushed
the
decode-unit
branch
from
1067a6d to
e0ba22f
Compare
This should be compiled as: function returning void Fixes: hyperledger-solang#1727 Signed-off-by: Sean Young <[email protected]>
seanyoung
force-pushed
the
decode-unit
branch
2 times, most recently
from
ef59d73 to
6c1a844
Compare
seanyoung
requested review from
xermicus,
LucasSte and
salaheldinsoliman
as code owners
|
Polkadot integration tests are failing because they've bitrotten. Nothing to do with this change. |
LucasSte
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be compiled as: function returning void
Fixes: #1727