fix: JS wrapper updates #231
Conversation
Signed-off-by: Ariel Gentile <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>
wrappers/javascript/package.json
Outdated
| @@ -55,7 +55,10 @@ | |||
| "tsconfig-paths": "4.1.0", | |||
| "typescript": "4.5.5" | |||
| }, | |||
| "resolutions": { | |||
| "ref-napi": "npm:@2060.io/ref-napi" | |||
There was a problem hiding this comment.
Can't we add this as a direct dependency for all the wrappers and not require the resolution anymore?
There was a problem hiding this comment.
I'm not sure if that would work because it is also an indirect dependency: ffi-napi requires it. In such case maybe we can also patch it to depend on the patched ref-napi as well.
There was a problem hiding this comment.
@TimoGlastra what about these latest changes? I needed some tweaks for types, but at the end seems to work fine. I think it's worth to put some effort on this considering the several problems users had in setting up these components for NodeJS.
genaris
force-pushed
the
fix/js-wrapper-updates
branch
from
3666633
to
44b7a58
Compare
Signed-off-by: Ariel Gentile <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>
There was a problem hiding this comment.
This is great! Would definitely help in making it easier to use these libraries (we should probably do it for all libraries).
Maybe we can also look at not hosting it under 2060 npm scope, but that's something we can look at later on (not sure what would be a good home)
| @@ -297,7 +297,6 @@ describe('bindings', () => { | |||
| revocationRegistryDefinition, | |||
| revocationRegistryDefinitionPrivate, | |||
| registryIndex: 9, | |||
| tailsPath, | |||
There was a problem hiding this comment.
tailsPath is not used anymore (eslint warning)
Some updates to JavaScript wrappers to match main
branchstatus:UpdateRevocationStatusListfor NodeJSFfiCredRevInfostructure has not been changed, even iftails_pathis not used anymore. @andrewwhitehead is this on purpose or should be removed from there as well?I went a bit more further and updated minimum node version to 18, which is in fact the minimum usable version due to the known performance issue of
ref-napi(which is patched). node 16 will reach its EOL next month anyway.