fixed build issue for JS wrappers #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
genaris
approved these changes
Oct 26, 2023
| @@ -244,7 +244,12 @@ jobs: | |||
| if: | | |||
| github.event_name == 'release' || | |||
| (github.event_name == 'workflow_dispatch' && github.event.inputs.publish-wrappers == 'true') | |||
| run: npx lerna publish from-package --no-push --no-private --yes --no-git-tag-version | |||
| run: | | |||
| if [[ $(cat lerna.json | grep version | head -1 | grep dev) ]]; then | |||
There was a problem hiding this comment.
Just a simple check to see if there is a dev inside the version field of the lerna.json. not the strictest way to do this, but I'd rather move to release-it or something else then to create a proper lerna fix for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the issue of not being able to build using PowerShell as node shell.
and closes #248