AnonCreds Credentials using the W3C Standard - implementation #271

Artemkaaas · 2023-11-10T08:54:34Z

W3C credential and presentation definitions: tied to AnonCreds W3C form
Method to convert legacy credential into W3C form
Method to convert AnonCreds W3C credential into legacy form
Methods to issue/process a credential in W3C form
Methods to create/verify a presentation in W3C form
Helper methods for W3C credential

Signed-off-by: Abdulbois <[email protected]>

Signed-off-by: artem.ivanov <[email protected]>

…thod Signed-off-by: artem.ivanov <[email protected]>

TimoGlastra · 2023-11-14T14:31:17Z

@Artemkaaas is this ready for review, or should it still be in draft?

Artemkaaas · 2023-11-14T14:33:51Z

@Artemkaaas is this ready for review, or should it still be in draft?

Yes. There is still some work to do internally, but in general it already provides implementation of all necessary APIs

…cation Signed-off-by: artem.ivanov <[email protected]>

Signed-off-by: artem.ivanov <[email protected]>

berendsliedrecht

Did not review everything yet, but here are some minor comments.

Cargo.toml

src/data_types/credential.rs

src/data_types/w3c/credential.rs

berendsliedrecht · 2023-11-21T09:59:45Z

src/data_types/w3c/credential.rs

+        W3CCredential {
+            context: ANONCREDS_CONTEXTS.clone(),
+            type_: ANONCREDS_CREDENTIAL_TYPES.clone(),
+            issuance_date: Utc::now(),
+            proof: OneOrMany::Many(Vec::new()),
+            ..Default::default()
+        }


This can just be the impl Default for W3CCredential....

berendsliedrecht · 2023-11-21T10:01:02Z

src/data_types/w3c/credential.rs

+        }
+    }
+
+    pub fn set_id(&mut self, id: URI) {


Not the biggest fan of this API right now, but I am also unsure what can be done to improve it.

src/data_types/w3c/credential_proof.rs

src/data_types/w3c/one_or_many.rs

src/ffi/cred_offer.rs

Signed-off-by: artem.ivanov <[email protected]>

swcurran · 2023-12-04T15:55:41Z

@andrewwhitehead @berendsliedrecht -- could you please take a final pass through this PR and, if appropriate, approve it?

Thanks!

Signed-off-by: artem.ivanov <[email protected]>

…tent with the design Signed-off-by: artem.ivanov <[email protected]>

berendsliedrecht

I have reviewed 23 out of 41 files. I will continue friday.

berendsliedrecht · 2023-12-06T21:31:11Z

src/data_types/w3c/credential.rs

+
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub enum CredentialStatusType {
+    AnonCredsCredentialStatusList2023,


Been a bit out of the loop, will this be a new revocation scheme or just a placeholder for future work?

It refers to the same revocation schema as we used before. We need to define a new typelike AnonCredsProof2023 for credentials and AnonCredsPresentationProof2023 for presentations.

src/data_types/w3c/presentation_proof.rs

berendsliedrecht · 2023-12-06T21:37:22Z

src/ffi/w3c/cred_offer.rs

+/// # Returns
+/// Error code
+#[no_mangle]
+pub extern "C" fn anoncreds_create_w3c_credential_offer(


I likely have missed some previous discussions surrounding this, but why is this method added? I have no real objection to it, just more curious.

We discussed during one of the community group calls.
There are 6 methods for running issuance/verification flow methods in total.
We have to duplicate at least 4 of them: create_credential, process_credential, create_presentation, verify_presentation.

credential_offer and credential_request are not changed for the current moment. It's clearer to use the same set of methods for running the whole w3c credential issuance process. Also, potentially offer and request can be adjusted for W3C standard somehow in future.

berendsliedrecht · 2023-12-06T21:39:14Z

src/ffi/w3c/credential.rs

+/// # Returns
+/// Error code
+#[no_mangle]
+pub extern "C" fn anoncreds_w3c_credential_set_id(


Is there a specific reason why we expose these set methods over FFI? IIRC we did not do that for the anoncreds credentials, is this a nice convience for w3c specifically after conversion or something?

We added these helper methods to provide an ability to set Non-AnonCreds Data Integrity Proof Signatures for generated W3C credential objects. So that W3C credentials may contain multiple signatures to use in future.
It's up to application whether to use these methods or add proof by itself.

berendsliedrecht · 2023-12-06T21:42:24Z

src/services/issuer.rs

+}
+
+impl<'a> CLCredentialIssuer<'a> {
+    pub(crate) fn init(


Is there a specific reason why this is not just new and why does it return a Result?

Can be updated.
CLCredentialIssuer returns Result only to be aligned with other CL helpers (like CLCredentialProver) which does more steps on the init and truly returns Result.

berendsliedrecht · 2023-12-06T21:43:55Z

src/services/prover.rs

-) -> Result<SubProofRequest> {
-    trace!("_build_sub_proof_request <<< req_attrs_for_credential: {:?}, req_predicates_for_credential: {:?}",
-           req_attrs_for_credential, req_predicates_for_credential);
+pub(crate) struct CLCredentialProver<'a> {


Could it be possible to just handle this without the lifetime? Whats the reason we need a ref?

It cannot because CLCredentialProver holds references requiring explicit lifetime definition

src/services/prover.rs

src/data_types/credential.rs

Signed-off-by: artem.ivanov <[email protected]>

# Conflicts: # docs/design/w3c/w3c-representation.md

swcurran · 2023-12-07T16:40:32Z

w00t!!!! Awesome work @Artemkaaas ! Good stuff.

Abdulbois and others added 10 commits November 7, 2023 09:08

feat: Add CredentialW3C credential format

d4471a7

Signed-off-by: Abdulbois <[email protected]>

feat: Work on credential conversion methods

6127276

Signed-off-by: artem.ivanov <[email protected]>

feat: W3C credential and presentation format support

cf062a3

Signed-off-by: artem.ivanov <[email protected]>

feat: Refactoring

9be394d

Signed-off-by: artem.ivanov <[email protected]>

feat: Applied code formatter

5fa8a90

Signed-off-by: artem.ivanov <[email protected]>

feat: Code refactoring and fixes

7def052

Signed-off-by: artem.ivanov <[email protected]>

feat: Reuse implemented service methods

4e3fb30

Signed-off-by: artem.ivanov <[email protected]>

feat: Changed reference to anoncreds-cs dependency

5d42a36

Signed-off-by: artem.ivanov <[email protected]>

Exclude design documents

e3a0f9b

Signed-off-by: artem.ivanov <[email protected]>

Code cleanup and refactoring

cbc46fc

Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas force-pushed the anoncreds-wc3 branch from d4a2912 to cbc46fc Compare November 10, 2023 09:22

Artemkaaas added 3 commits November 10, 2023 12:28

fix: Fixed sample code in function documentation

7f531aa

Signed-off-by: artem.ivanov <[email protected]>

Use W3C credentials/presentation in multiple credentials test

3f6519b

Signed-off-by: artem.ivanov <[email protected]>

Refactored mapping structure

ea7188b

Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas force-pushed the anoncreds-wc3 branch 4 times, most recently from 9620287 to 511a669 Compare November 13, 2023 14:51

Added function to retrieve credential attribute

572001a

Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas force-pushed the anoncreds-wc3 branch from 511a669 to 572001a Compare November 13, 2023 14:54

Different predicate representation + pass cred def into conversion me…

65eb5b6

…thod Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas changed the title ~~AnonCreds Credentials and Presentations using the W3C Verifiable Credentials Data Model Standard~~ AnonCreds Credentials using the W3C Standard Nov 14, 2023

Support case incentive case + refactored presentation creation/verifi…

731734f

…cation Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas force-pushed the anoncreds-wc3 branch from 309d723 to 731734f Compare November 15, 2023 09:07

Fixed issue with taking revocation state

5676fd8

Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas force-pushed the anoncreds-wc3 branch from 5919a45 to 61f2627 Compare November 15, 2023 10:11

Fixed formatting

30099e0

Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas force-pushed the anoncreds-wc3 branch from 61f2627 to 30099e0 Compare November 15, 2023 10:43

Artemkaaas force-pushed the anoncreds-wc3 branch from db87012 to 498b28e Compare November 20, 2023 07:51

Artemkaaas added 2 commits November 20, 2023 12:04

Use enum for credential value

e4bc7ad

Signed-off-by: artem.ivanov <[email protected]>

Use credential status property for exposing revocation registry id

142af17

Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas force-pushed the anoncreds-wc3 branch from 9495af1 to 142af17 Compare November 21, 2023 10:07

berendsliedrecht reviewed Nov 21, 2023

View reviewed changes

Artemkaaas force-pushed the anoncreds-wc3 branch from a27d6d9 to a26b4cc Compare November 21, 2023 13:42

Moved w3c methods to separate folders

cdebb35

Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas force-pushed the anoncreds-wc3 branch 2 times, most recently from 93c08f1 to 410ef34 Compare November 22, 2023 07:51

Move w3c modules under the feature

37444c4

Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas force-pushed the anoncreds-wc3 branch from 410ef34 to 37444c4 Compare November 22, 2023 07:52

Artemkaaas added 3 commits November 22, 2023 11:47

Changed method name

354d92b

Signed-off-by: artem.ivanov <[email protected]>

Use serde alias for type and id fields

fa67696

Signed-off-by: artem.ivanov <[email protected]>

Refactored demo tests to work with both legacy and w3c formats

ac39a95

Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas force-pushed the anoncreds-wc3 branch from 309306f to ac39a95 Compare November 29, 2023 10:04

Artemkaaas added 2 commits December 1, 2023 11:09

Code refactoring

dd376e8

Signed-off-by: artem.ivanov <[email protected]>

Code refactoring

95b01e2

Signed-off-by: artem.ivanov <[email protected]>

Artemkaaas force-pushed the anoncreds-wc3 branch from b71971b to 95b01e2 Compare December 2, 2023 08:04

swcurran requested a review from andrewwhitehead December 4, 2023 15:54

Artemkaaas added 2 commits December 4, 2023 20:38

Added check of encoded attributes

b825666

Signed-off-by: artem.ivanov <[email protected]>

Changed name of create and verify presentation functions to be consis…

8267bc9

…tent with the design Signed-off-by: artem.ivanov <[email protected]>

berendsliedrecht reviewed Dec 6, 2023

View reviewed changes

andrewwhitehead reviewed Dec 6, 2023

View reviewed changes

src/data_types/credential.rs Show resolved Hide resolved

andrewwhitehead reviewed Dec 6, 2023

View reviewed changes

src/data_types/credential.rs Show resolved Hide resolved

Artemkaaas added 2 commits December 7, 2023 09:17

Process review comments

77df074

Signed-off-by: artem.ivanov <[email protected]>

Merge remote-tracking branch 'origin/main' into anoncreds-wc3

59a8a8c

# Conflicts: # docs/design/w3c/w3c-representation.md

andrewwhitehead approved these changes Dec 7, 2023

View reviewed changes

swcurran merged commit fd44f1b into hyperledger:main Dec 7, 2023
26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AnonCreds Credentials using the W3C Standard - implementation #271

AnonCreds Credentials using the W3C Standard - implementation #271

Artemkaaas commented Nov 10, 2023

TimoGlastra commented Nov 14, 2023

Artemkaaas commented Nov 14, 2023

berendsliedrecht left a comment

berendsliedrecht Nov 21, 2023

berendsliedrecht Nov 21, 2023

swcurran commented Dec 4, 2023

berendsliedrecht left a comment

berendsliedrecht Dec 6, 2023

Artemkaaas Dec 7, 2023

berendsliedrecht Dec 6, 2023

Artemkaaas Dec 7, 2023

berendsliedrecht Dec 6, 2023

Artemkaaas Dec 7, 2023

berendsliedrecht Dec 6, 2023

Artemkaaas Dec 7, 2023

berendsliedrecht Dec 6, 2023

Artemkaaas Dec 7, 2023

swcurran commented Dec 7, 2023

AnonCreds Credentials using the W3C Standard - implementation #271

AnonCreds Credentials using the W3C Standard - implementation #271

Conversation

Artemkaaas commented Nov 10, 2023

TimoGlastra commented Nov 14, 2023

Artemkaaas commented Nov 14, 2023

berendsliedrecht left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swcurran commented Dec 4, 2023

berendsliedrecht left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swcurran commented Dec 7, 2023