refactor: only issuer id for legacy->w3c #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
commented
Feb 5, 2024
src/ffi/w3c/credential.rs
Outdated
| @@ -148,8 +149,8 @@ pub extern "C" fn anoncreds_credential_to_w3c( | |||
| None => None, | |||
| }; | |||
|
|
|||
| let w3c_credential = | |||
| credential_to_w3c(credential, cred_def.load()?.cast_ref()?, w3c_version)?; | |||
| let issuer_id = IssuerId::new(issuer_id).expect("Invalid issuer ID"); | |||
There was a problem hiding this comment.
I'm not a rust expert. Is this validated and handled correctly?
There was a problem hiding this comment.
If new returns an error it will panic. You can use ? instead to not panic but pass along the error back over ffi.
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running into some issues when needing to transform between legacy -> w3c anoncreds as the method requires the cred_def to be passed. It seems the cred_def is only required for the issuer_id, and this PR updates it to only require a string issuer_id rather than the whole cred def.
In our case we know the issuer_id, but we'd have to resolve the cred_def from the ledger